Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App icon in .dmg at some sizes incorrect #863

Closed
ivanmaeder opened this issue Oct 31, 2016 · 4 comments
Closed

App icon in .dmg at some sizes incorrect #863

ivanmaeder opened this issue Oct 31, 2016 · 4 comments

Comments

@ivanmaeder
Copy link

ivanmaeder commented Oct 31, 2016

  • Version: 7.15.2
  • Target: macOS

Really strange issue, I can't find any help anywhere or references to the same issue.

The build is fine, except in the generated .dmg, in the window that shows the app icon and the icon to the applications folder, the app icon is shown with the default Atom icon... but only at certain sizes!

When you open the .dmg the app icon is shown with the Atom icon, but using the slider to resize the icons, at the smallest size the correct icon is shown, and at larger sizes. Here are some screenshots:

screen shot 2016-10-31 at 14 35 57

screen shot 2016-10-31 at 14 35 59

screen shot 2016-10-31 at 14 36 04

The icons are generated by creating an .iconset dir and then using iconutil.

I've checked the original .png files again and again and these are the details:

Filename Size px/inch
icon_16x16.png 16x16 72
[email protected] 32x32 72
icon_32x32.png 32x32 72
[email protected] 64x64 72
icon_128x128.png 128x128 72
[email protected] 256x256 72
icon_256x256.png 256x256 72
[email protected] 512x512 72
icon_512x512.png 512x512 72
[email protected] 1024x1024 72

The actual .app that is generated in the dist/ folder has the correct icon. Changing the zoom in Finder to see different sizes of this icon is fine (the correct icon is shown in all sizes).

I tried the same with the .app extracted from the .dmg and the default Mac app icon is showing at larger sizes, with the Atom icon showing at smaller sizes:

screen shot 2016-10-31 at 14 47 20

screen shot 2016-10-31 at 14 47 31

Launchpad shows the default Atom icon.

I'm running El Capitan 10.11.6 (15G1004).

I'm running the build with npm run dist and this is the part from package.json where the build is configured:

{
  "scripts": {
    "dist": "rimraf ./dist && build"
  },
  "devDependencies": {
    "electron": "^1.4.3",
    "electron-builder": "^7.15.2",
    "rimraf": "^2.5.4"
  },
  "build": {
    "appId": "com.website.bolt",
    "extraFiles": "tools",
    "mac": {
    }
  }
}

Just to be sure the mac section is being used I added a background entry and it was used (I tried just as a test to set the iconSize field to 16 but no change was visible).

Any ideas of what I could try? Thanks!

@develar
Copy link
Member

develar commented Nov 2, 2016

Please see #840 (comment) Does it help?

@ivanmaeder
Copy link
Author

ivanmaeder commented Nov 2, 2016

Thanks @develar. Yes, that fixed part of the issue. The app icon inside the "installation" window (where the app icon is shown with the arrow pointing to the Applications/ folder) is now correct. Cool :)

But after dragging the app into the Applications/ folder, the icon shown there is the default macOS app icon.

Any other ideas?

@develar
Copy link
Member

develar commented Nov 2, 2016

Any other ideas?

It is macOS cache issues. Production is not affected.

Duplicates #840

@develar develar closed this as completed Nov 2, 2016
@ivanmaeder
Copy link
Author

OK good to know. I tried it on someone's computer that was new to the app and it all worked. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants