Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSIS Uninstall Script? #528

Closed
ghost opened this issue Jun 20, 2016 · 9 comments · May be fixed by qcif/data-curator#563
Closed

NSIS Uninstall Script? #528

ghost opened this issue Jun 20, 2016 · 9 comments · May be fixed by qcif/data-curator#563

Comments

@ghost
Copy link

ghost commented Jun 20, 2016

Is it possible to have uninstallation instructions? How does that work? I need to delete a directory (roaming/App Name) on uninstallation.

@develar
Copy link
Member

develar commented Jun 26, 2016

Fixed, will be deleted: RMDir /r "$APPDATA\${PRODUCT_NAME}"

@ghost
Copy link
Author

ghost commented Jun 26, 2016

And this will be done only on uninstall? Or also on reinstall (of the same version)

It should of course never happen when installing a newer version.

I suppose only on uninstall would be best.

@develar
Copy link
Member

develar commented Jun 26, 2016

Yes, only on uninstall.

develar added a commit to develar/electron-builder that referenced this issue Jun 26, 2016
@develar develar closed this as completed Jun 26, 2016
@artpol
Copy link

artpol commented Nov 5, 2016

I'am testing on Windows 7 x86, nsis uninstaller doesn't remove "C:\Users\MyName\AppData\Roaming\My App Id" with Local storage and other files. Is it possible to remove it automatically on uninstallation?
Thanks for help!
Electron builder version - 7.17.0

@develar
Copy link
Member

develar commented Nov 6, 2016

Yes, app data is not removed. Do you want compile flag (I.e. Produce installer that will delete by default) or runtime option (ask user)?

@artpol
Copy link

artpol commented Nov 6, 2016

"Produce installer that will delete by default" - will be nice for my task. Because when user uninstall application, and install it again later, application can't understand that this is first run (to realise custom logic), because old data in place.

@develar
Copy link
Member

develar commented Nov 6, 2016

@artpol What about auto updates?

@artpol
Copy link

artpol commented Nov 6, 2016

During the auto-update, delete data should not be. We are talking only about the manual removal of the application, If it is possible to distinguish between them.

@develar
Copy link
Member

develar commented Nov 6, 2016

@artpol I am not sure that your way is correct, but maybe it is ok and suitable for your application. Filed as #885

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants