Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differentiate Uninstall from Update (NSIS) #1092

Closed
McPo opened this issue Jan 6, 2017 · 4 comments
Closed

Differentiate Uninstall from Update (NSIS) #1092

McPo opened this issue Jan 6, 2017 · 4 comments

Comments

@McPo
Copy link
Contributor

McPo commented Jan 6, 2017

10.5.0

NSIS

Ive created a custom NSIS script to prompt the user as to whether or not to remove the User Data.
I used the 'customUnInstall' macro.

However when updating the application, customUninstall macro is called. Which results in the user being asked if it wants to wipe user data when updating.

Instead a customUpdate macro should be called.

Related: #528 #885

@McPo
Copy link
Contributor Author

McPo commented Jan 6, 2017

This can be resolved by wrapping any such code in:

${IfNot} ${Silent}
${endIf}

I realise my initial request is unreasonable, as you would need to define when customUpdate would be called. (It would likely be called at the end of an install, not during during the installation phase).

@McPo McPo closed this as completed Jan 6, 2017
@develar
Copy link
Member

develar commented Jan 6, 2017

You can detect is it auto update —

@develar
Copy link
Member

develar commented Jan 7, 2017

Ive created a custom NSIS script to prompt the user as to whether or not to remove the User Data.

PR welcome ;)

@JassiSingh08
Copy link

10.5.0

NSIS

Ive created a custom NSIS script to prompt the user as to whether or not to remove the User Data. I used the 'customUnInstall' macro.

However when updating the application, customUninstall macro is called. Which results in the user being asked if it wants to wipe user data when updating.

Instead a customUpdate macro should be called.

Related: #528 #885

hey I know its far from late but can you share your script? Iam getting the exact problem of deleting items even on update on my script as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants