Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app-builder-lib): Allow using lowercase value for certificateSha1 #4684

Merged

Conversation

MortalKastor
Copy link
Contributor

Resolves #4631 by transforming both Thumbprint and certificateSha1 to uppercase before comparing them.

@develar develar merged commit 5390bb6 into electron-userland:master Feb 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

code signature only works when thumbprint is typed in uppercase
2 participants