-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update electron updater #276
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 1b80a46 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## develop #276 +/- ##
============================================
+ Coverage 0 57.01% +57.01%
============================================
Files 0 516 +516
Lines 0 21468 +21468
Branches 0 5748 +5748
============================================
+ Hits 0 12240 +12240
- Misses 0 9182 +9182
- Partials 0 46 +46
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Screenshots: ✅
There are no changes in the screenshots for this PR. If this is expected, you are good to go. |
2757c8a
to
1b80a46
Compare
📝 Description
As there was a bug in the electron-updater package a long time ago, we were using our own fork of the lib. Since then, the PRs have been merged:
autoInstallOnAppQuit = false
on macOS electron-userland/electron-builder#5271and there where a few updates since them.
We are trying to move back to the official repository for the updater and put it up to date as well.
❓ Context
lld
✅ Checklist
📸 Demo
HODL video incoming
🚀 Expectations to reach
App should still autoupdate without any issues
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.