Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update electron updater #276

Closed
wants to merge 5 commits into from
Closed

update electron updater #276

wants to merge 5 commits into from

Conversation

valpinkman
Copy link
Member

📝 Description

As there was a bug in the electron-updater package a long time ago, we were using our own fork of the lib. Since then, the PRs have been merged:

❓ Context

  • Impacted projects: lld
  • Linked resource(s): ``

✅ Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

📸 Demo

HODL video incoming

🚀 Expectations to reach

App should still autoupdate without any issues

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@vercel
Copy link

vercel bot commented Jun 7, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
live-common-tools ✅ Ready (Inspect) Visit Preview Jun 8, 2022 at 9:40AM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Jun 8, 2022 at 9:40AM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Jun 8, 2022 at 9:40AM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Jun 8, 2022 at 9:40AM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Jun 7, 2022

🦋 Changeset detected

Latest commit: 1b80a46

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
ledger-live-desktop Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Jun 7, 2022

Codecov Report

Merging #276 (942ab0a) into develop (4a67632) will increase coverage by 57.01%.
The diff coverage is n/a.

❗ Current head 942ab0a differs from pull request most recent head 1b80a46. Consider uploading reports for the commit 1b80a46 to get more accurate results

@@             Coverage Diff              @@
##           develop     #276       +/-   ##
============================================
+ Coverage         0   57.01%   +57.01%     
============================================
  Files            0      516      +516     
  Lines            0    21468    +21468     
  Branches         0     5748     +5748     
============================================
+ Hits             0    12240    +12240     
- Misses           0     9182     +9182     
- Partials         0       46       +46     
Flag Coverage Δ
test 57.01% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libs/ledger-live-common/src/manager/index.ts 37.63% <0.00%> (ø)
...dger-live-common/src/countervalues/api/api.mock.ts 94.82% <0.00%> (ø)
...mon/src/families/solana/deviceTransactionConfig.ts 4.49% <0.00%> (ø)
.../src/families/solana/api/chain/validators/index.ts 100.00% <0.00%> (ø)
.../ledger-live-common/src/account/groupOperations.ts 98.46% <0.00%> (ø)
...mon/src/families/elrond/deviceTransactionConfig.ts 12.50% <0.00%> (ø)
.../ledger-live-common/src/families/tron/constants.ts 100.00% <0.00%> (ø)
.../ledger-live-common/src/families/elrond/preload.ts 40.00% <0.00%> (ø)
libs/ledger-live-common/src/hw/getDeviceInfo.ts 82.22% <0.00%> (ø)
.../src/families/polkadot/js-getFeesForTransaction.ts 57.14% <0.00%> (ø)
... and 506 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a67632...1b80a46. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Jun 7, 2022

@valpinkman

Screenshots: ✅

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli common Has changes in live-common desktop Has changes in LLD HODL Do not merge mobile Has changes in LLM ui Has changes in the design system library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants