Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code signature only works when thumbprint is typed in uppercase #4631

Closed
pablocar80 opened this issue Feb 2, 2020 · 0 comments · Fixed by #4684
Closed

code signature only works when thumbprint is typed in uppercase #4631

pablocar80 opened this issue Feb 2, 2020 · 0 comments · Fixed by #4684

Comments

@pablocar80
Copy link

latest version

@develar
My code signing stopped working and I figured it was caused by these lines in windowsCodeSign.ts in the fix for issue #4291:

if ((certificateSubjectName != null && !certInfo.Subject.includes(certificateSubjectName))
    || certInfo.Thumbprint !== certificateSha1) {

The problem is that Windows usually shows you thumbprints in lowercase:

image

So copying and pasting the correct thumprint from the certificate will not work because the line of code compares it with the output of powershell which is uppercase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant