-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executableArgs do not work on snap #4587
Comments
To answer, need to try. I suggest to do some changes and prepare PR. I will take responsibility to finish PR as nessary. |
We are also facing issues, in our case we are trying to add --no-sandbox but its not added, and we are using the latest version of the builder. So the AppImage generated doesn't run for example on debian 10.
|
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Can we please get some action on this item? It would resolve the issue that AppImages cannot work properly on Debian, as the --no-sandbox flag will not work without this fix. The executableArgs section is supposed to be functional. tx |
I have quite simple requirement to have app start on boot and to do it minimized. So far snap gives me the biggest headache. I already have autoStart working and now I am trying to make it start hidden. From what I've read the best way is to add
--hidden
argument when it is starting on boot. For that in snap desktop file I need this line:Exec=myApp --hidden
I've tried adding
executableArgs: ['--hidden']
to linux target, but it did not work. From what I could find this condition seems to be at fault - https://github.com/electron-userland/electron-builder/blob/master/packages/app-builder-lib/src/targets/LinuxTargetHelper.ts#L95exec
is equal topackager.executableName
, so it cannot benull
:https://github.com/electron-userland/electron-builder/blob/master/packages/app-builder-lib/src/targets/snap.ts#L182
I would be happy to make a PR to fix this but I am not sure if
executableArgs
can be safely moved out of thatif
. Or maybe there is some better solution?This could also solve AppImage issues such as #4496
The text was updated successfully, but these errors were encountered: