feat: Extending linux executableArgs option to be utilized for Snap…

… target (fixes #4587) (#7198)
electron-userland · Oct 20, 2022 · a2ce9a7 · a2ce9a7
1 parent 5616f23
commit a2ce9a7
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/.changeset/empty-ligers-turn.md b/.changeset/empty-ligers-turn.md
@@ -0,0 +1,5 @@
+---
+"app-builder-lib": major
+---
+
+Extending `linux` executableArgs option to be utilized for Snap target
diff --git a/packages/app-builder-lib/src/targets/snap.ts b/packages/app-builder-lib/src/targets/snap.ts
@@ -195,12 +195,19 @@ export default class SnapTarget extends Target {
       Icon: "${SNAP}/meta/gui/icon.png",
     })
 
+    const extraAppArgs: Array<string> = options.executableArgs ?? []
     if (this.isElectronVersionGreaterOrEqualThan("5.0.0") && !isBrowserSandboxAllowed(snap)) {
-      args.push("--extraAppArgs=--no-sandbox")
+      const noSandboxArg = "--no-sandbox"
+      if (!extraAppArgs.includes(noSandboxArg)) {
+        extraAppArgs.push(noSandboxArg)
+      }
       if (this.isUseTemplateApp) {
         args.push("--exclude", "chrome-sandbox")
       }
     }
+    if (extraAppArgs.length > 0) {
+      args.push("--extraAppArgs=" + extraAppArgs.join(" "))
+    }
 
     if (snap.compression != null) {
       args.push("--compression", snap.compression)