-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linux build fails at icon conversion #239
Linux build fails at icon conversion #239
Comments
Thanks, will be fixed. Do you have 48x48 icon (just curios)? |
You can try pre-release version — set version to Reproduced — on Travis server icns2png doesn't work at all — |
Thanks the |
@jbleuzen Thanks for confirmation. What I want — since you in any case have to provide icns file for OS X, it will be better if tool will use it to generate linux icon set. Well, it seems that icns2png is broken on Linux. Well, "could I just provide the icons "manually"" makes sense. |
fix: Linux build fails at icon conversion #239
Confirmed here too, Linux builds correctly now. Thanks for the fix! |
Hi , im facing the same problem so i thought o update the electron-builder verstion to |
@pavankumarkatakam On CI server or dev machine? This fix is released already. |
Im using actually |
@pavankumarkatakam Please attach build log here. Please check that your icns file is correct. |
Hi @develar , Here is my logs
I have installed the required packages mentioned in wiki page. And im just checking my app with electron first time here is my development package json for building the linux
|
Hmm... it seems you delete your
Also, you should not clean output directory — electron-builder does it automatically. |
Hi @develar , I have changed that command to But still getting the same error. also this is my package.json
|
Please And
Please list content of the /tmp/test-ico directory. |
version is
output of second statement
output of command ls -al /tmp/test-ico
|
Please change path in the command to your icns file. |
As i mentioned before im not using any icns file, i just mentioned |
Docs: You must have build/icon.icns file or "build/icons directory — filename must contains size (e.g. 32x32.png))" |
I have added the build/icons/X*X.png files, but now it is showing the another error.
I have installed |
Output of
|
I have just updated to 3.15.0, but im getting the same error, i have also installed and update the xz-utils
install fpm as well |
|
It is DMG icon "which will be shown when mounted". Yeah, it is not user-friendly and confusing. |
Okay, last question about icons since what you said worked out for me :) |
No, it is windows only fail. And to be honest – we can fix this Squirrel.Windows bug.
It is better to fix Squirrel.Windows bug and do not require http url. |
After updating to
And on osx, it detects the icon, but never sets it properly for my
|
Fixed. Need to change the name to from |
@develar
Project structure contains build should appear in "installBuilder" (package gets created but P.S. Assume I know nothing about linux box. |
@JimiC https://github.com/electron-userland/electron-builder/wiki/Multi-Platform-Build#linux Please read docs and install |
For such case we provide docker image — https://github.com/electron-userland/electron-builder/tree/master/docker — but it is not documented and, so, for advanced users only. |
@develar OK. I have to admit it. I fail miserably when it comes to RTFM (Read The F****ing Manual) 😳 |
@develar If I'm to use |
@JimiC we use it as is. Just convert to standard layout without any size requirements. It is your responsibility now to provide required sizes. No checks on our side. |
@JimiC develar had an example where he named the
And it worked for me after trying that, if you're just trying to get something up and running. Of course you can always just specify an |
@JimiC No. For OS X 512x512 is required (no checks on our side) and better to provide 1024x1024. |
@develar 😱 It's worst than I thought. Even for Linux? |
@develar Resolved. As usually the user didn't paid attention to the specified options. 👊 |
i.e. we create mapping for 512 and assume that this file is exist. |
I am having a similar (if not the same) issue
I have a icon.icns 128 x 128 in my specified buildResources directory which is working properly when generating a MacOS installer but failing when generating a Linux installer on MacOS. I apologize in advance if this is a simple issue that I am overlooking 😅 |
@Mercieral "For OS X 512x512 is required (no checks on our side) and better to provide 1024x1024." To generate linux icons from |
I now have a 1024x1024 icon.icns but I am still getting an error that seems to be related to the icon
|
@Mercieral As a workaround, convert your icns using https://iconverticons.com/online/ (PNG - download all) and put all png files to build/icons directory. BTW, consider to use AppImage target instead of deb. |
@develar That seemed to work, thank you! Also, I was just using build --linux so I assume deb was the default target. |
@Mercieral deb is the default for Linux but possibly you might be interested in the AppImage target, too. |
|
Building a
deb
with the latest release (2.9.5) I get the following error:I have provided a
build/icon.icns
file (generated using these steps: http://blog.macsales.com/28492-create-your-own-custom-icons-in-10-7-5-or-later). When I look what's in the/tmp/electron-builder-30935NzzLT2KzUll7/
folder, I see that it created the following icons:Looks like 64 and 128 is missing.
I am building the linux deb from an Ubuntu 15.10 machine.
Any ideas what's going on? Alternatively, could I just provide the icons "manually" (I already have all those pngs anyways)?
The text was updated successfully, but these errors were encountered: