Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linux target to build task #26

Merged
merged 2 commits into from
May 28, 2017
Merged

Add linux target to build task #26

merged 2 commits into from
May 28, 2017

Conversation

louisbourque
Copy link
Contributor

Hello,
This pull request adds a linux build task to hopefully resolve #7.
I had to add the icons as separate PNGs due to this bug I encountered: electron-userland/electron-builder#239 (comment)

This pull request also fixes a bug where when closing Partyshare with the X button, the icon would continue to show, but clicking on it does nothing. I changed it so the ipfs daemon is stopped when the X button is pressed. Not sure if this was the intended functionality of the button,but I can change if necessary.

App icon would remain visible after quitting, but nothing happened when you clicked it
@bhstahl
Copy link
Member

bhstahl commented May 28, 2017

Great! Thanks for this PR @louisbourque! I'm almost ready with Release 1.1.0. Let's merge this with that release.

@bhstahl bhstahl merged commit fb102a0 into BusterLabs:master May 28, 2017
@louisbourque
Copy link
Contributor Author

Awesome! Thanks for accepting my pull request. I'm happy I was able to contribute.

I'm not very familiar with how electron works. Does this mean you can now generate the Linux builds? When I was working on it, it didn't seem to build a Mac .dmg file. I can add the link to the gh-pages branch, but I'm not sure how the publish step works.

Also, just a heads up, the 'fix_asar' gave me errors (sed: can't read s|run(cmd, args|run(cmd.replace("app.asar", "app.asar.unpacked"), args|: No such file or directory), so I just manually changed the "node_modules/ipfsd-ctl/src/exec.js" to use const command = run(cmd.replace("app.asar", "app.asar.unpacked"), args, opts). Once #14 is fixed, this won't be a problem any more of course.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add linux target to build task
2 participants