Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for hoisted node_modules (lerna + yarn workspaces)? #2205

Closed
evgenykochetkov opened this issue Oct 15, 2017 · 4 comments
Closed

Support for hoisted node_modules (lerna + yarn workspaces)? #2205

evgenykochetkov opened this issue Oct 15, 2017 · 4 comments
Assignees
Labels

Comments

@evgenykochetkov
Copy link

  • Version: 19.34.2
  • Target: mac, windows

In a standard lerna + yarn workspaces monorepo hoisted dependencies are not included in asar:

repo_root
    node_modules
        ... hoisted common deps, not included in asar
    packages
        electron_app
            node_modules
                ... only these are included
        other_packages

If there is no official workaround, I'd love to submit a PR, but would really appreciate some guidance.
So far I've changed _readInstalled to look for packages listed in package.json until root, like require does, but that did not completely solved the issue and I'm stuck :(

@evgenykochetkov
Copy link
Author

Also, this seems kind of related to #1837

@develar develar self-assigned this Oct 17, 2017
@evgenykochetkov
Copy link
Author

UPD: I solved it, will create a PR soon

develar added a commit to develar/electron-builder that referenced this issue Oct 17, 2017
@develar
Copy link
Member

develar commented Oct 17, 2017

@evgenykochetkov Sorry, develar@7844c3b

@evgenykochetkov
Copy link
Author

@develar Oh, nice 👍🏻

develar added a commit to develar/electron-builder that referenced this issue Oct 18, 2017
develar added a commit to develar/electron-builder that referenced this issue Oct 18, 2017
develar added a commit to develar/electron-builder that referenced this issue Oct 18, 2017
develar added a commit to develar/electron-builder that referenced this issue Oct 18, 2017
develar added a commit to develar/electron-builder that referenced this issue Oct 18, 2017
develar added a commit to develar/electron-builder that referenced this issue Oct 18, 2017
develar added a commit to develar/electron-builder that referenced this issue Oct 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants