Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symbolic linked dependency's node_modules is not included in ASAR #1837

Closed
guiguan opened this issue Jul 18, 2017 · 5 comments
Closed

Symbolic linked dependency's node_modules is not included in ASAR #1837

guiguan opened this issue Jul 18, 2017 · 5 comments

Comments

@guiguan
Copy link

guiguan commented Jul 18, 2017

  • Version: 19.16.1
  • Target: mac --dir

If the dependency listed in package.json is a symbolic link, for example, created by yarn link, then that dependency's node_modules is not included in final ASAR, which made target app unable to run. This worked in electron-builder 19.10.0

@wshamim

@dgeibi
Copy link

dgeibi commented Sep 4, 2017

I have the same problem after running lerna bootstrap or npm link xx.

@develar
Copy link
Member

develar commented Sep 4, 2017

Consider to use yarn workspaces as workaround.

@dgeibi
Copy link

dgeibi commented Sep 8, 2017

Yarn workspaces didn't help. Symbolic linked dependency's dependencies can't be found.

Yarn placed the symbolic linked sub-packages' dependencies in the parent project's root directory's node_modules, and I think they should be resolved like regular packages.

  • yarn: v1.0.1
  • electron-builder: v19.28.1
  • Target: AppImage

@develar
Copy link
Member

develar commented Feb 1, 2018

I hope it is fixed now.

@develar develar closed this as completed Feb 1, 2018
@dsanders11
Copy link
Member

@develar, this is still a problem for me. Dependencies which were symbolically linked via yarn link do not get packaged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants