Add makepri.exe binaries for windows builds #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
According to https://developer.microsoft.com/en-us/windows/downloads/windows-10-sdk, you have latest SDK, 👍 |
|
Thanks, will be released soon. |
|
whoa, that was lightning fast! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi folks,
I am looking into automating the addition of custom assets to electron-builder based on the steps described in electron-userland/electron-builder#987 (comment)
This requires the availability of the
makepriwindows binaries, and this is my attempt at adding them.I copied the binaries from my local windows kit folder, from
Windows Kits\10\bin\10.0.15063.0\x86andWindows Kits\10\bin\10.0.15063.0\x64, respectively. Is this the best place to get these files?Please let me know if I'm doing this right, or if I need to change anything.
Thanks!