-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
appx - wrong icon / how to set assets #987
Comments
If you can and want — please file PR. |
Will try, guess I'll have to start here https://github.com/electron-userland/electron-builder/blob/master/src/targets/appx.ts#L49 |
@black-snow Ouch, sorry, it is already implemented :) Just put
|
@develar You sure? I put |
Yes. Only size. |
Alright, that works. Some quirks, though.
Sources look okay, though. The images in Do we need more assets? (https://msdn.microsoft.com/en-us/windows/uwp/controls-and-patterns/tiles-and-notifications-app-assets) Guess we should add a note to the wiki for appx. // edit: Where does the |
Thanks, fixed.
I don't know. To investigate. @black-snow Would you like to help and fix this issue? |
@develar of course. At first I'll unpack the appx and stuff all the assets in there that a VS plugin generated for me. Will report back. /edit1: I used this VS plugin to generate a bunch of assets. I stuffed them into the appx/assets but there's still some blurry images. The icon on the install-screen is blurry and the taskbar icon still looks as in the screenshot above. I wonder why there's a /edit2: /edit3: MS pointed me to this - sadly, the _unplated thing ain't seem to work |
Also there's some manual steps that have to be done in order to publish the appx in the Windows Store. Maybe we can automate these, too. There's four fields in the manifest that need to be set:
Publisher is already correctly set (CN=...). PublisherDisplayName was correct in my case, too. There might be cases where someone needs to set a different one. I'd say we add an option for each of the remaining three fields. Maybe @develar Shall I open a new issue? Option names okay? I would try to file a PR for this. Doc would also need an update of course. I haven't fixed the asset thing yet. |
👍 Also, I think, it makes sense to allow any extra properties in the
PR will be enough if you will prepare it. |
For the icons here's what I had to (thanks to Matteo Pagani from Microsoft): For the assets:
If you have your assets:
Key was the That's quite a bunch of steps. I fear I have no time this year left to work on this :| |
#1017 for the extra custom properties |
@black-snow Did you successfully submit appx to windows store? |
@develar yup. I'm still thinking of automating the assets workflow. |
@black-snow Hi, upping a 2 years old issue but, any easier way found to do this ? I'm struggling with the same error (blurry / margin in taskbar icon) |
@baldash sadly no - I haven't revisited this issue since then. But let me hear if you find anything new! |
@black-snow your instructions were very helpful, I fixed my main problem thanks to them ! but I still have one last issue, even when tweaking the target-size and target-size_unplated values, my icon doesn't seem to change its size: Do eventually remember anything in relation to that ? That could be helpful ^^ (I followed everything except the VS part cause I already had my set of icons) |
Okay fixed I'm just a bad person who doesn't read the doc properly. The issue was that for a resource named "SampleAppx.44x44.png", I created a So, two things here
Ref link: https://docs.microsoft.com/en-us/windows/msix/desktop/desktop-to-uwp-manual-conversion |
When building for windows store the
icon.ico
isn't used in a couple places. E. g. the installed software list shows a default electron icon. Start menu as well.I found those default icons in
assets
. I haven't yet figured out how to use my own icon for those assets.The text was updated successfully, but these errors were encountered: