Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #1060
Rebased the old POC up to master -- figured I'd create the PR to help discussion.
With iOS's plugin processing, the 'hull filling' happens first. In android, it seems to happen after the plugin processing, so we need to defer the replacements.
The
fs
use and replacement function was lifted from the iOS implementation, but was then wrapped in anasync
function side-effect creator for later processing. This is probably inefficient, but I held back on optimizations, pending discussion.