Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another staple react-native plugin -
This is a WIP -- it can't be merged as-is until this issue is resolved: electrode-io/electrode-native#1060 because it uses
relaceInFile
on Android (currently not supported)RN-gesture-handler has a slightly involved installation process:
In our case, that means adding the edited
createRootView
to ElectrodeReactActivityDelegate.java2 replacements are made:
RNGestureHandlerEnabledRootView
import@Override
ing thecreateRootView
method:<four spaces>}\n}
, which depends on code style/indentation. Not great..We've been using this config for a few months (using a patched version of
0.30.x
-- see info in the linked issue) -- I figured I'd at least get it up here to start a discussion.Thank you!