Remove mentions of the "Advanced sorting" toggle #2960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation previews: |
|
This pull request does not have a backport label. Could you fix it @xcrzx? 🙏
NOTE: |
There was a problem hiding this comment.
Really appreciate you taking care of this @xcrzx ! I left two minor suggestions for your consideration. Also, the all-rules.png image needs to be refreshed, but we can probably take care of that if needed. The image shows up in the Create a detection rule page and the Manage detection rules page.
xcrzx
force-pushed
the
remove-advanced-sorting
branch
from
b3681c6 to
cd2401f
Compare
Good catch! Updated the image as well |
mergify bot
pushed a commit
that referenced
this pull request
Feb 13, 2023
(cherry picked from commit 3c37bc6)
jmikell821
pushed a commit
that referenced
this pull request
Feb 14, 2023
(cherry picked from commit 3c37bc6) Co-authored-by: Dmitrii Shevchenko <[email protected]>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #2947
Summary
The advanced sorting toggle has been removed from the rules management tables; see elastic/kibana#138907. Now, users can sort by any table column without that toggle.