Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add detailed results to CCS queries #349

Merged
merged 2 commits into from
Dec 13, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions elastic/logs/challenges/cross-clusters-search.json
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@
"param-source": "workflow-selector",
"workflow": {{workflow | tojson }},
"workflow-target": {{ target_index | tojson }},
"detailed-results": true,
"task-offset": {{ loop.index }},
"request-params": {{ p_query_request_params | tojson(indent=2) }}
},
Expand All @@ -73,6 +74,7 @@
"param-source": "workflow-selector",
"workflow": {{workflow | tojson }},
"workflow-target": {{ target_index | tojson }},
"detailed-results": true,
"task-offset": {{ loop.index }},
"request-params": {
"ccs_minimize_roundtrips": false
Expand Down
4 changes: 3 additions & 1 deletion elastic/shared/parameter_sources/workflow_selector.py
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,9 @@ def __init__(self, track, params, **kwargs):
# for testing purposes only we allow a configurable now function
self._utc_now = kwargs.get("utc_now", datetime.utcnow)
self._init_date = self._utc_now().replace(tzinfo=timezone.utc)
self._detailed_results = track.selected_challenge_or_default.parameters.get("detailed-results", False)
self._detailed_results = params.get(
"detailed-results", track.selected_challenge_or_default.parameters.get("detailed-results", False)
)
self._workflow_target = params.get(
"workflow-target",
track.selected_challenge_or_default.parameters.get("workflow-target"),
Expand Down