Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add detailed results to CCS queries #349

Merged
merged 2 commits into from
Dec 13, 2022

Conversation

b-deam
Copy link
Member

@b-deam b-deam commented Nov 22, 2022

With the merging of elastic/rally#1618 and elastic/rally#1619 we add the collection of shard meta-data for each search request with the intention of allowing us to visualise the number of shards hit and skipped by each query, an important metric for CCS behaviour.

@b-deam b-deam requested a review from DJRickyB November 22, 2022 23:24
@b-deam b-deam self-assigned this Nov 22, 2022
@javanna
Copy link
Member

javanna commented Dec 6, 2022

++ thanks a lot for doing this @b-deam !

@b-deam
Copy link
Member Author

b-deam commented Dec 12, 2022

👋 @DJRickyB - If you have some spare cycles this week would you mind reviewing?

Copy link
Contributor

@DJRickyB DJRickyB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Sorry for the delay

@b-deam b-deam merged commit 34e8fb6 into elastic:master Dec 13, 2022
b-deam added a commit that referenced this pull request Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants