[Cloud Security] Add support for required conditional groups of variables #855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsoriano
reviewed
Jan 14, 2025
seanrathier
force-pushed
the
required-fields
branch
from
e890688 to
347202b
Compare
jsoriano
reviewed
Jan 15, 2025
jsoriano
previously approved these changes
Jan 16, 2025
mrodm
reviewed
Jan 17, 2025
| @@ -515,6 +515,8 @@ spec: | |||
| description: Can input be defined multiple times | |||
| type: boolean | |||
| default: false | |||
| required_vars: | |||
There was a problem hiding this comment.
Should this be added also into input packages ? @jsoriano @seanrathier
There was a problem hiding this comment.
We could add there later if needed. @seanrathier do you need this for your current use case?
There was a problem hiding this comment.
No, I only need it in stream/inputs
💚 Build Succeeded
History
|
jsoriano
approved these changes
Jan 22, 2025
6 tasks
jsoriano
added a commit
that referenced
this pull request
Jan 23, 2025
Add semantic validation and some additional tests for required variable groups added in #855.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add support for conditionally required groups of variables.
Why is it important?
In some cases, policy templates like CloudFlare and CSPM will have mutually exclusive input variables that are required.
For example, access_key and secret_key or the session_token is required
Checklist
test/packagesthat prove my change is effective.spec/changelog.yml.Related issues