[Cloud Security] add required_vars validation rules and default CSPM and Asset Inventory to agentless deployment #12363
+198
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewkroh
added
the
Integration:cloud_security_posture
seanrathier
changed the title
5 tasks
seanrathier
force-pushed
the
required-fields
branch
from
15f6b82 to
6c6632d
Compare
seanrathier
changed the title
andrewkroh
added
the
Team:Cloud Security
2 tasks
seanrathier
changed the title
opauloh
approved these changes
Jan 23, 2025
Comment on lines
+48
to
+94
| - type: cloudbeat/asset_inventory_aws | ||
| title: AWS Asset Inventory | ||
| description: AWS Asset Inventory | ||
| vars: | ||
| - name: cloud_formation_template | ||
| type: text | ||
| title: CloudFormation Template | ||
| multi: false | ||
| required: true | ||
| show_user: false | ||
| description: Template URL to Cloud Formation Quick Create Stack | ||
| # ACCOUNT_TYPE value should be either "single-account" or "organization-account" | ||
| default: https://console.aws.amazon.com/cloudformation/home#/stacks/quickcreate?templateURL=https://elastic-cspm-cft.s3.eu-central-1.amazonaws.com/cloudformation-asset-inventory-ACCOUNT_TYPE-8.17.0.yml&stackName=Elastic-Cloud-Security-Posture-Management¶m_EnrollmentToken=FLEET_ENROLLMENT_TOKEN¶m_FleetUrl=FLEET_URL¶m_ElasticAgentVersion=KIBANA_VERSION¶m_ElasticArtifactServer=https://artifacts.elastic.co/downloads/beats/elastic-agent | ||
| - name: cloud_formation_credentials_template | ||
| type: text | ||
| title: CloudFormation Credentials Template | ||
| multi: false | ||
| required: true | ||
| show_user: false | ||
| description: Template URL to Cloud Formation Cloud Credentials Stack | ||
| # ACCOUNT_TYPE value should be either "single-account" or "organization-account" | ||
| default: https://console.aws.amazon.com/cloudformation/home#/stacks/quickcreate?templateURL=https://elastic-cspm-cft.s3.eu-central-1.amazonaws.com/cloudformation-asset-inventory-direct-access-key-ACCOUNT_TYPE-8.17.0.yml | ||
| - type: cloudbeat/asset_inventory_azure | ||
| title: Azure Asset Inventory | ||
| description: Azure Asset Inventory | ||
| vars: | ||
| - name: arm_template_url | ||
| type: text | ||
| title: ARM Template URL | ||
| multi: false | ||
| required: true | ||
| show_user: false | ||
| description: A URL to the ARM Template for creating a new deployment | ||
| # ACCOUNT_TYPE value should be either "single-account" or "organization-account" | ||
| default: https://portal.azure.com/#create/Microsoft.Template/uri/https%3A%2F%2Fraw.githubusercontent.com%2Felastic%2Fcloudbeat%2F8.17%2Fdeploy%2Fasset-inventory-arm%2FARM-for-ACCOUNT_TYPE.json | ||
| - type: cloudbeat/asset_inventory_gcp | ||
| title: GCP Asset Inventory | ||
| description: GCP Asset Inventory | ||
| vars: | ||
| - name: cloud_shell_url | ||
| type: text | ||
| title: CloudShell URL | ||
| multi: false | ||
| required: true | ||
| show_user: false | ||
| description: A URL to CloudShell for creating a new deployment | ||
| default: https://shell.cloud.google.com/cloudshell/?ephemeral=true&cloudshell_git_repo=https%3A%2F%2Fgithub.com%2Felastic%2Fcloudbeat&cloudshell_git_branch=8.17&cloudshell_workspace=deploy%2Fdeployment-manager&show=terminal |
There was a problem hiding this comment.
was that an IDE auto-formatting?
There was a problem hiding this comment.
I think so. I ran the elastic-package build lint on it. That may have changed it.
Omolola-Akinleye
previously requested changes
Jan 24, 2025
This was referenced Jan 26, 2025
|
/test |
seanrathier
force-pushed
the
required-fields
branch
from
9c8cc3e to
bf7c727
Compare
🚀 Benchmarks reportPackage
|
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
findings |
52631.58 | 43478.26 | -9153.32 (-17.39%) | 💔 |
To see the full report comment with /test benchmark fullreport
|
💚 Build Succeeded
History
cc @seanrathier |
|
Package cloud_asset_inventory - 0.8.0 containing this change is available at https://epr.elastic.co/package/cloud_asset_inventory/0.8.0/ |
|
Package cloud_security_posture - 1.13.0-preview02 containing this change is available at https://epr.elastic.co/package/cloud_security_posture/1.13.0-preview02/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
required_vars validation rules for CSPM integration and default agentless deployments.
Add required_vars validation rules for CSPM integration for conditionally required fields.
Defaulting CSPM and Asset Inventory to agentless deployments.
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots