Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix changelog entries #545

Merged
merged 1 commit into from
Jun 20, 2023
Merged

Fix changelog entries #545

merged 1 commit into from
Jun 20, 2023

Conversation

mrodm
Copy link
Contributor

@mrodm mrodm commented Jun 20, 2023

What does this PR do?

Fix changelog entries to be in the following version to be released.

Follow-up #526

@mrodm mrodm self-assigned this Jun 20, 2023
@mrodm mrodm requested a review from a team as a code owner June 20, 2023 11:13
@mrodm mrodm requested a review from marc-gr June 20, 2023 11:14
@elasticmachine
Copy link

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-20T11:13:38.388+0000

  • Duration: 8 min 35 sec

Test stats 🧪

Test Results
Failed 0
Passed 874
Skipped 0
Total 874

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (8/8) 💚
Files 73.333% (22/30) 👍
Classes 76.19% (32/42) 👍
Methods 59.091% (78/132) 👍
Lines 45.201% (730/1615) 👍
Conditionals 100.0% (0/0) 💚

jsoriano
jsoriano approved these changes Jun 20, 2023
View reviewed changes
Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "Prepare for next version" change can be removed.

@mrodm
Copy link
Contributor Author

mrodm commented Jun 20, 2023

The "Prepare for next version" change can be removed.

I'll remove that entry when preparing the following version 2.9.0 👍

@mrodm mrodm merged commit 66a84a6 into elastic:main Jun 20, 2023
@mrodm mrodm deleted the update_changelog_2.9.0 branch June 20, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlind23 jlind23 jlind23 approved these changes

@jsoriano jsoriano jsoriano approved these changes

@marc-gr marc-gr Awaiting requested review from marc-gr

Assignees

@mrodm mrodm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mrodm @elasticmachine @jsoriano @jlind23