Add variants and terraform and k8s input service deployers #526
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
|
/test |
| @@ -0,0 +1,40 @@ | |||
| - name: IP | |||
There was a problem hiding this comment.
Should this file config.yml and fields.yml be added to the specification ?
Are those files required if the folder is present?
There was a problem hiding this comment.
The folder is supposed to be a placeholder for any resources required by the benchmark, the idea of not making it based on the benchmark name was based on the idea that different benchmarks may want to use the same resources. So both the folder names and its contents were just not enforced any particular structure.
There was a problem hiding this comment.
@marc-gr Would that mean that there could be any file inside those folders ? and also, there could be any number of folders with any name ?
There was a problem hiding this comment.
even though I see this not being so common, yes it could be any number of them
There was a problem hiding this comment.
Talked offline, a new entry will be added to define resource folders explicitly. And those folder could contain any resource.
What does this PR do?
Why is it important?
Checklist
test/packagesthat prove my change is effective.spec/changelog.yml.