-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Updates changelog for 7.0.0-alpha2 #347
Conversation
docs/CHANGELOG.asciidoc
Outdated
|
||
//=== Regressions | ||
* Fixes CPoissonMeanConjugate sampling error. {ml-pull}335[#335] | ||
* Removes out-of-phase buckets feature. {ml-pull}318[#318] (issue: {ml-issue}302[#302]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We deliberately decided not to document this as the removed feature was never documented or tested and nobody should ever have used it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok! I've added "non-issue" so it doesn't get picked up.
docs/CHANGELOG.asciidoc
Outdated
* Linear scaling change detection. {ml-pull}25[#25] | ||
* Implements an absolute goodness-of-fit test to accept a change. {ml-pull}21[#21] | ||
* Wires in change detection/modelling to our univariate time series model. {ml-pull}11[#11] | ||
* First pass implementation of support functionality for change detection and modelling. {ml-pull}9[#9] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix cause of "MERGE: Sum mode samples = 0, total samples = 4.43521.." log errors ({ml-pull}294[294]) | ||
|
||
//=== Regressions | ||
* Fixes CPoissonMeanConjugate sampling error. {ml-pull}335[#335] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's true that this isn't currently in a GA version, but it will be in 6.6. So when the eventual 7.0.0 GA release notes are created it shouldn't be in there. Might it be worth adding a comment here to say it should be removed when consolidating into the GA 7.0.0 release notes?
Thanks @droberts195, I've cleaned up the list based on your feedback |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR removes the 6.x items from the changelog in master and adds PRs that are closed with the v7.0.0 label. It omits PRs that were labelled with release numbers that are already generally available.