[ML] Wire in change detection/modelling to our univariate time series model #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge-modelling-part-2
…ge-modelling-part-2
droberts195
reviewed
Mar 13, 2018
| const std::string LAST_PROPAGATION_TIME_6_3_TAG{"c"}; | ||
| const std::string PERIODICITY_TEST_6_3_TAG{"d"}; | ||
| const std::string CALENDAR_CYCLIC_TEST_6_3_TAG{"e"}; | ||
| const std::string COMPONENTS_6_3_TAG{"f"}; |
There was a problem hiding this comment.
This PR is labelled 7.0, but doesn't this change imply that the feature branch must be merged before 6.3 feature freeze?
There was a problem hiding this comment.
That is a very good point! This change was mostly made before I reverted the change to bump state. I'll change this and double check that there aren't other cases where I've changed persisted state.
tveasey
changed the title
droberts195
pushed a commit
that referenced
this pull request
Apr 23, 2018
… model (#11) This wires in change detection and starts some unit testing of CTimeSeriesModel with change points. There is some more work to be done to avoid using level shifts to try and fit other types of change points, such as scaling.
|
Removing version label as this is a feature branch PR and it causes confusion when generating release notes. (For interest this was eventually merged to 6.4 and above in #92.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is work in progress, but I'm submitting to avoid this PR growing larger. This wires in change detection and starts some unit testing of
CTimeSeriesModelwith change points. There is some more work to be done to avoid using level shifts to try and fit other types of change points, such as scaling.Effects
This will affect all our results, but it is work in progress so it isn't anticipated that we will test results without further changes.