Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added faraday-* and ruby2_keywords notices to licences list #13126

Merged
merged 1 commit into from
Aug 13, 2021

Conversation

andsel
Copy link
Contributor

@andsel andsel commented Aug 13, 2021

Release notes

[rn:skip]

What does this PR do?

  • Adds NOTICES files for some faraday submodules
  • Align licenseMapping.csv

Why is it important/What is the impact to the user?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files (and/or docker env variables)
  • I have added tests that prove my fix is effective or that my feature works

Author's Checklist

  • [ ]

How to test this PR locally

  • checkout the branch
  • run bin/dependencies-report --csv /tmp/deps.csv is must be green, on master it currently fails

Related issues

Use cases

Screenshots

Logs

Copy link
Contributor

@kaisecheng kaisecheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing the build. I have tested locally and it passed with a clean build.

@andsel
Copy link
Contributor Author

andsel commented Aug 13, 2021

The red CI seems unrelated to this changes

@andsel andsel merged commit 542dce8 into elastic:master Aug 13, 2021
andsel added a commit to andsel/logstash that referenced this pull request Aug 13, 2021
andsel added a commit that referenced this pull request Aug 13, 2021
kares added a commit to kares/logstash that referenced this pull request Aug 16, 2021
* 7.15:
  Release notes for 7.14.0 (elastic#13133)
  [backport 7.x] Added faraday-* and ruby2_keywords notices to licences list (elastic#13126) (elastic#13128)
kares added a commit to kares/logstash that referenced this pull request Aug 23, 2021
* master:
  Update releases list (elastic#13149)
  Bundler: freeze lockfile on run, and "normalize" platform on plugin changes (elastic#13015)
  Doc: Move shared region tags for breaking changes to 8.0.0 content (elastic#13131)
  Update Snakeyaml version to 1.29 (elastic#13129)
  Doc: Add breaking changes to breaking changes page (elastic#13130)
  Added faraday-* and ruby2_keywords notices to licences list (elastic#13126)
  Release notes draft for 8.0.0-alpha1 (elastic#13098)
  valid variable expansion for the batch files (elastic#12912)
  Doc: Enhance and expand DLQ docs (elastic#12959)
  Update releases list with 7.13.4 (elastic#13088)
  Doc:Fix typo and adjust keystore text (elastic#12779)
  doc: add pipeline.ecs_compatibility docs (elastic#12421)
  ecs_compatibility: revert breaking change; keep `disabled` as default for 8.0.0 (elastic#13080)
  Doc: Add kafka schema registry setting to troubleshooting (elastic#13073)
  [Test] Fix Unix acceptance tests (elastic#13071)
  Move retrieval of Stack version from Gradle's configuration to execution (elastic#13042)
  Update releases list with 6.8.17 and 7.13.3 (elastic#13041)
  Docs: keep elastic_app_search output meta-data (elastic#13048)
  Fix LS benchmarking tool to work with releases >= 7.10.0 (elastic#13052)
  Revert "Change Gradle's :logstash-integration-tests:integrationTests task to depends on copyES (elastic#12847)" (elastic#13045)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants