Move retrieval of Stack version from Gradle's configuration to execution #13042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
andsel
force-pushed
the
fix/move_retrieve_of_stack_version_into_gradle_execution_phase
branch
from
4d7d4a2 to
03b0604
Compare
andsel
added a commit
to andsel/logstash
that referenced
this pull request
Jul 12, 2021
…ion (elastic#13042) The Gradle's configuration of task should be as fast as possible and don't break the build. This commit moves retrieval of Elastic Stack version from the remote registry to the execution phase of the tasks. Also the tasks that depends on this has received the same change (downloadEs and check EsSHA), moving from configuration to execution phase. Close elastic#13030 (cherry picked from commit cef339c)
andsel
added a commit
that referenced
this pull request
Jul 13, 2021
…tion to execution (#13042) (#13066) The Gradle's configuration of task should be as fast as possible and don't break the build. This commit moves retrieval of Elastic Stack version from the remote registry to the execution phase of the tasks. Also the tasks that depends on this has received the same change (downloadEs and check EsSHA), moving from configuration to execution phase. Close #13030 (cherry picked from commit cef339c)
andsel
added a commit
to andsel/logstash
that referenced
this pull request
Jul 13, 2021
…ion (elastic#13042) The Gradle's configuration of task should be as fast as possible and don't break the build. This commit moves retrieval of Elastic Stack version from the remote registry to the execution phase of the tasks. Also the tasks that depends on this has received the same change (downloadEs and check EsSHA), moving from configuration to execution phase. Close elastic#13030 (cherry picked from commit cef339c)
andsel
added a commit
to andsel/logstash
that referenced
this pull request
Jul 13, 2021
…ion (elastic#13042) The Gradle's configuration of task should be as fast as possible and don't break the build. This commit moves retrieval of Elastic Stack version from the remote registry to the execution phase of the tasks. Also the tasks that depends on this has received the same change (downloadEs and check EsSHA), moving from configuration to execution phase. Close elastic#13030 (cherry picked from commit cef339c)
andsel
added a commit
that referenced
this pull request
Jul 21, 2021
…ion (#13042) (#13067) The Gradle's configuration of task should be as fast as possible and don't break the build. This commit moves retrieval of Elastic Stack version from the remote registry to the execution phase of the tasks. Also the tasks that depends on this has received the same change (downloadEs and check EsSHA), moving from configuration to execution phase. Close #13030 (cherry picked from commit cef339c)
kares
added a commit
to kares/logstash
that referenced
this pull request
Aug 23, 2021
* master: Update releases list (elastic#13149) Bundler: freeze lockfile on run, and "normalize" platform on plugin changes (elastic#13015) Doc: Move shared region tags for breaking changes to 8.0.0 content (elastic#13131) Update Snakeyaml version to 1.29 (elastic#13129) Doc: Add breaking changes to breaking changes page (elastic#13130) Added faraday-* and ruby2_keywords notices to licences list (elastic#13126) Release notes draft for 8.0.0-alpha1 (elastic#13098) valid variable expansion for the batch files (elastic#12912) Doc: Enhance and expand DLQ docs (elastic#12959) Update releases list with 7.13.4 (elastic#13088) Doc:Fix typo and adjust keystore text (elastic#12779) doc: add pipeline.ecs_compatibility docs (elastic#12421) ecs_compatibility: revert breaking change; keep `disabled` as default for 8.0.0 (elastic#13080) Doc: Add kafka schema registry setting to troubleshooting (elastic#13073) [Test] Fix Unix acceptance tests (elastic#13071) Move retrieval of Stack version from Gradle's configuration to execution (elastic#13042) Update releases list with 6.8.17 and 7.13.3 (elastic#13041) Docs: keep elastic_app_search output meta-data (elastic#13048) Fix LS benchmarking tool to work with releases >= 7.10.0 (elastic#13052) Revert "Change Gradle's :logstash-integration-tests:integrationTests task to depends on copyES (elastic#12847)" (elastic#13045)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
[rn:skip]
What does this PR do?
This PR moves the downloading of Elasticsearch and Filebeat artifacts, used in integration tests, to happen at Gradle's execution phase instead of configuration time. This let the configuration step to work also it the requested integration artifacts aren't yet published.
Why is it important/What is the impact to the user?
It has to be possible to run Gradle tasks related to package creation and running unit test also if the stack version defined in
versions.ymlis not yet available. In this case integration tests is admitted to fail.Checklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration files (and/or docker env variables)I have added tests that prove my fix is effective or that my feature worksAuthor's Checklist
rake artifact:allbuild artifacts without downloading ES or Filebeat artifactsHow to test this PR locally
Modify
versions.ymllocally to a version not yet published, for example7.15.0and try to run the unit tests./gradlew :logstash-core:unitTestsand./gradlew :logstash-core:rubyTests. Those should work without downloading any Elasticserach package, checkbuild/folder. Run integration tests./gradlew runIntegrationTestand it should fail to find7.15.0.Related issues
Use cases
Screenshots
Logs