-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Canvas] Improvements to datasource expressions including SQL parameter support and array leniency #99549
[Canvas] Improvements to datasource expressions including SQL parameter support and array leniency #99549
Conversation
…code, remove last spot of legacy elasticsearch client from canvas
@elasticmachine merge upstream |
merge conflict between base and head |
Pinging @elastic/kibana-presentation (Team:Presentation) |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, but I do want to bring up one concern that's more a side effect of this becoming the default.
The expression functions esdocs
essql
etc have a dependency on the Canvas searchService
. The functions are added to expression service on plugin setup, but the Canvas services are only started once you get to Canvas. If some other plugin ever goes to use any of these functions, they are going to get an error.
Could we inject whatever the reportingService
into those functions.
OR (event better)
move those functions out into their own plugin and handle the start/setup/service needs there. This will ensure it doesn't have any future dependencies on Canvas.
…er support and array leniency (elastic#99549) * Remove es sql strategy from behind Labs project, remove legacy essql code, remove last spot of legacy elasticsearch client from canvas * clean up test * fix es field test * remove comment Co-authored-by: Kibana Machine <[email protected]>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
…er support and array leniency (#99549) (#103527) * Remove es sql strategy from behind Labs project, remove legacy essql code, remove last spot of legacy elasticsearch client from canvas * clean up test * fix es field test * remove comment Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Poff Poffenberger <[email protected]>
💔 Build Failed
Failed CI StepsTest FailuresKibana Pipeline / general / task-queue-process-24 / X-Pack Endpoint API Integration Tests.x-pack/test/security_solution_endpoint_api_int/apis/metadata·ts.Endpoint plugin test metadata api POST /api/endpoint/metadata when index is not empty metadata api should return one entry for each host with default pagingStandard Out
Stack Trace
Kibana Pipeline / general / task-queue-process-24 / X-Pack Endpoint API Integration Tests.x-pack/test/security_solution_endpoint_api_int/apis/metadata·ts.Endpoint plugin test metadata api POST /api/endpoint/metadata when index is not empty metadata api should return one entry for each host with default pagingStandard Out
Stack Trace
Kibana Pipeline / general / Chrome UI Functional Tests.test/functional/apps/visualize/_vega_chart·ts.visualize app visualize ciGroup12 vega chart in visualize app vega chart initial render should have view and control containersStandard Out
Stack Trace
Metrics [docs]Public APIs missing comments
Page load bundle
Unknown metric groupsAPI count
References to deprecated APIs
History
To update your PR or re-run it, just comment with: |
Summary
essql
,esdocs
, andescount
from the serverCloses #97305
Closes #75068
Closes #94457 (New function includes this)
Closes #56229 (New strategy enables
field_multi_value_leniency
)Closes #53836 (Same issue as above)