Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Canvas datasource expression functions into their own plugin #103525

Closed
poffdeluxe opened this issue Jun 28, 2021 · 2 comments
Closed

Move Canvas datasource expression functions into their own plugin #103525

poffdeluxe opened this issue Jun 28, 2021 · 2 comments
Labels
Feature:Canvas impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas technical debt Improvement of the software architecture and operational architecture

Comments

@poffdeluxe
Copy link
Contributor

In #99549, we've made the esdocs, essql, and escount expression functions for Canvas dependent on Canvas's searchService. The downside with this is that we can't use these functions outside of Canvas since that searchService is setup through the Canvas plugin lifecycle.

We should move these functions to their own plugin that can handle their own setup and use the data.search service.
@poffdeluxe poffdeluxe added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:medium Medium Level of Effort technical debt Improvement of the software architecture and operational architecture impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Feature:Canvas labels Jun 28, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@nreese
Copy link
Contributor

nreese commented Apr 6, 2023

Closing as not planned

@nreese nreese closed this as completed Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:Canvas impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nreese @poffdeluxe @elasticmachine