-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Adds runtime fields #99395
[DOCS] Adds runtime fields #99395
Conversation
Pinging @elastic/kibana-docs (Team:Docs) |
We might want to add something to the bullet about selecting type that clarifies that your scripts output MUST match the output type or the script will not work. They should get an error, but it's probably worth making it clear that it will not convert any types. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments. Can be done later, but it would be cool to extend the tutorial to contain a real-world example of how runtime field can be used.
I'm not sure I would use the language "we add fields to documents." I get the intent of what it's trying to say, but runtime fields are added to index patterns and that could be misleading in how it's worded. The first two bullets in the value list might make more sense reversed also, the schema-less concept being first. In the list of product tools that work, we should be re-enforcing that they work anywhere an index pattern is used. Instead of an app to app concept to think about, the model is they work everywhere except.... and list anything that doesn't support index patterns. For the create runtime fields section, we should use Discover or Lens as an example. Not everyone has access to index pattern management. That will be less limiting for someone wanting to try them. The Lens page looks ok to me. |
I don't see "we add fields to documents" in this PR, but I reversed the bulleted list of benefits.
I've removed the list, but I'd still like to call out Discover and Lens in the bulleted list of benefits.
This section is geared towards admins, who should have access to index pattern management. For analysts that want to create runtime fields, they can refer to the Discover and Lens |
This reverts commit 537732a.
@elasticmachine run elasticsearch-ci/docs |
❌ Author of the following commits did not sign a Contributor Agreement: Please, read and sign the above mentioned agreement if you want to contribute to this project |
* [DOCS] Runtime fields * [DOCS] Runtime fields * Adds examples and Lens changes * Review comments * Adds redirects * Review comments * Revert "Review comments" This reverts commit 537732a. * Review comments * Fixes broken link * Removes duplicate link Co-authored-by: Kaarina Tungseth <[email protected]>
* [DOCS] Runtime fields * [DOCS] Runtime fields * Adds examples and Lens changes * Review comments * Adds redirects * Review comments * Revert "Review comments" This reverts commit 537732a. * Review comments * Fixes broken link * Removes duplicate link Co-authored-by: Kaarina Tungseth <[email protected]>
* [DOCS] Runtime fields * [DOCS] Runtime fields * Adds examples and Lens changes * Review comments * Adds redirects * Review comments * Revert "Review comments" This reverts commit 537732a. * Review comments * Fixes broken link * Removes duplicate link Co-authored-by: Kaarina Tungseth <[email protected]> Co-authored-by: Kaarina Tungseth <[email protected]>
* [DOCS] Runtime fields * [DOCS] Runtime fields * Adds examples and Lens changes * Review comments * Adds redirects * Review comments * Revert "Review comments" This reverts commit 537732a. * Review comments * Fixes broken link * Removes duplicate link Co-authored-by: Kaarina Tungseth <[email protected]> Co-authored-by: Kaarina Tungseth <[email protected]>
Summary