Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Adds a section on runtime fields to the Discover intro #99143

Merged
merged 5 commits into from
May 12, 2021

Conversation

gchaps
Copy link
Contributor

@gchaps gchaps commented May 3, 2021

Summary

This PR adds a section to the docs about using runtime fields in Discover.

Preview:
https://kibana_99143.docs-preview.app.elstc.co/guide/en/kibana/master/discover.html

@gchaps gchaps added Team:Docs v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.14.0 v7.13.0 labels May 3, 2021
@gchaps gchaps requested a review from kertal May 4, 2021 20:24
@gchaps gchaps marked this pull request as ready for review May 4, 2021 20:24
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

@gchaps gchaps requested review from shaunmcgough and elastic-jb May 4, 2021 20:24
@shaunmcgough
Copy link

Thanks, Gail. This looks great. @timroes would you add anything more to this?

@timroes
Copy link
Contributor

timroes commented May 5, 2021

Do we have a proper documentation for runtime fields already that we could link to from here? I feel just given an example with "hello world" will leave users with tons of open questions (like how to I actually do useful stuff with this now and access documents). I don't think we should cover this here in this place, but should have a central runtime fields documentation that we can link to. So in case that already exists, we should link to it already, otherwise try to remember hard to link to it later once it's written :D

@kertal kertal requested a review from majagrubic May 5, 2021 08:08
Copy link

@shaunmcgough shaunmcgough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides linking to more technical docs, this is a good addition.


. Turn on *Set value*.

. Use the Painless scripting language to define the field:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think it would be good to add a link to the Painless docs here:
https://www.elastic.co/guide/en/elasticsearch/reference/master/modules-scripting-painless.html

@KOTungseth
Copy link
Contributor

@timroes @shaunmcgough @kertal the PR for runtime fields is #99395. I've added a link from the Discover docs to the runtime fields page.

Copy link

@elastic-jb elastic-jb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@gchaps
Copy link
Contributor Author

gchaps commented May 12, 2021

@elasticmachine merge upstream

@gchaps gchaps merged commit 9b2e8c9 into elastic:master May 12, 2021
gchaps added a commit to gchaps/kibana that referenced this pull request May 12, 2021
…c#99143)

* [DOCS] Adds a section on runtime fields to the Discover intro

* [DOCS] Updates images

* Adds link to runtime fields doc

* [DOCS] Adds note about filtering, editing, and deleting runtime fields

Co-authored-by: KOTungseth <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>
gchaps added a commit to gchaps/kibana that referenced this pull request May 12, 2021
…c#99143)

* [DOCS] Adds a section on runtime fields to the Discover intro

* [DOCS] Updates images

* Adds link to runtime fields doc

* [DOCS] Adds note about filtering, editing, and deleting runtime fields

Co-authored-by: KOTungseth <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>
gchaps added a commit that referenced this pull request May 12, 2021
#99999)

* [DOCS] Adds a section on runtime fields to the Discover intro

* [DOCS] Updates images

* Adds link to runtime fields doc

* [DOCS] Adds note about filtering, editing, and deleting runtime fields

Co-authored-by: KOTungseth <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: KOTungseth <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>
gchaps added a commit that referenced this pull request May 12, 2021
#99998)

* [DOCS] Adds a section on runtime fields to the Discover intro

* [DOCS] Updates images

* Adds link to runtime fields doc

* [DOCS] Adds note about filtering, editing, and deleting runtime fields

Co-authored-by: KOTungseth <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: KOTungseth <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Docs v7.13.0 v7.14.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants