Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Revert "Add essql search strategy and integrate in canvas (#94754)" #98841

Merged
merged 3 commits into from
May 3, 2021
Merged

Revert "Revert "Add essql search strategy and integrate in canvas (#94754)" #98841

merged 3 commits into from
May 3, 2021

Conversation

poffdeluxe
Copy link
Contributor

Restores #94754 and updates squel to use safe-squel

@poffdeluxe poffdeluxe added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed labels Apr 29, 2021
@poffdeluxe poffdeluxe requested review from a team as code owners April 29, 2021 21:06
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

afharo
afharo approved these changes Apr 30, 2021
View reviewed changes
Copy link
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Telemetry schema changes LGTM!

clintandrewhall
clintandrewhall approved these changes Apr 30, 2021
View reviewed changes
Copy link
Contributor

@clintandrewhall clintandrewhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rock on!

@poffdeluxe
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
canvas 1089 1100 +11

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
presentationUtil 85 94 +9

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
canvas 1.3MB 1.3MB +59.6KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
canvas 520.1KB 534.1KB +14.0KB
presentationUtil 40.5KB 41.1KB +579.0B
total +14.6KB
Unknown metric groups

API count

id before after diff
presentationUtil 87 96 +9

async chunk count

id before after diff
canvas 7 8 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@poffdeluxe poffdeluxe merged commit da785ea into elastic:master May 3, 2021
@poffdeluxe poffdeluxe deleted the feature/essqlStrategy-v2 branch May 3, 2021 17:42
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request May 3, 2021
@poffdeluxe @kibanamachine
Revert "Revert "Add essql search strategy and integrate in canvas (el…
649177d 
…astic#94754)" (elastic#98841)

* Revert "Revert "Add essql search strategy and integrate in canvas (elastic#94754)""

This reverts commit 0f15a12.

* Update squel usage to safe-squel

Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine kibanamachine mentioned this pull request May 3, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request May 3, 2021
@kibanamachine @poffdeluxe
Revert "Revert "Add essql search strategy and integrate in canvas (#9…
3fdc2b9 
…4754)" (#98841) (#99086)

* Revert "Revert "Add essql search strategy and integrate in canvas (#94754)""

This reverts commit 0f15a12.

* Update squel usage to safe-squel

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Poff Poffenberger <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afharo afharo afharo approved these changes

@pgayvallet pgayvallet pgayvallet approved these changes

@clintandrewhall clintandrewhall clintandrewhall approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes review Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@poffdeluxe @elasticmachine @kibanamachine @clintandrewhall @pgayvallet @afharo