Add essql search strategy and integrate in canvas #94754
Conversation
poffdeluxe
force-pushed
the
feature/essqlSearchStrategy
branch
from
df67330 to
4094c41
Compare
x-pack/plugins/canvas/canvas_plugin_src/functions/browser/essql.ts
Outdated
Show resolved
Hide resolved
| }; | ||
| }; | ||
|
|
||
| return from(searchUntilEnd()); |
There was a problem hiding this comment.
As you mentioned, this is probably a good place to actually give partial results on the observable. I'm happy to walk through this with you.
Also, would a cancel method need to actually close the cursor?
…sql temporary function
…add parameter arg for essql
poffdeluxe
force-pushed
the
feature/essqlSearchStrategy
branch
from
7004865 to
10c23ba
Compare
poffdeluxe
added
auto-backport
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
💚 Build SucceededMetrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
Unknown metric groupsAPI count
async chunk count
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
LGTM 👍 I loaded up all the sample workpads and tested a few SQL queries and it seems to be working the same.
The only thing I noticed was when I used the new param arg for the essql function, this is what the sidebar looks like.
Not a blocker, but we should consider adding a form control for the new arg, so the user doesn't end up with this warning that forces them to edit their essql query via the expression editor only.
* Add essql search strategy, new escount temporary function, and new essql temporary function * Move old es* functions to legacy, add esdocs to use search strategy, add parameter arg for essql * Clean up * cleanup * cleanup * Move request builder files to common * cleanup * add comment * PR Feedback * Removing old types * update type * Add data.search to labs and fix error messages * Fix function help type * Add data service to usage collector types * Update telemetry * remove unrelated telemetry change * Enable multi value leniency for SQL queries * Display data service lab project
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
|
This was reverted with 0f15a12. |
…astic#94754)"" This reverts commit 0f15a12.
…4754)" (#98841) * Revert "Revert "Add essql search strategy and integrate in canvas (#94754)"" This reverts commit 0f15a12. * Update squel usage to safe-squel Co-authored-by: Kibana Machine <[email protected]>
…astic#94754)" (elastic#98841) * Revert "Revert "Add essql search strategy and integrate in canvas (elastic#94754)"" This reverts commit 0f15a12. * Update squel usage to safe-squel Co-authored-by: Kibana Machine <[email protected]>
…4754)" (#98841) (#99086) * Revert "Revert "Add essql search strategy and integrate in canvas (#94754)"" This reverts commit 0f15a12. * Update squel usage to safe-squel Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Poff Poffenberger <[email protected]>
Summary
data.searchservicefield_multi_value_leniencyto essql calls to prevent arrays from blowing up sql queries (Canvas needs to handle arrays in elasticsearch raw documents better #56229 and Canvas: Default SQL statement produces error with sample data #53836)All new Search Service changes (using new search strategy, browser functions) are loaded as a new Lab Project with the new changes active by default. The gameplan is to merge this into 7.x (after 7.13 is cut) with everything active so we can ensure that there aren't any strange side effects that we haven't considered. If all goes well, before 7.14, we will decouple the new changes from the Lab Project, set them to be the default, and remove the legacy server-side functions.