Support 1 Kibana and 1 Elasticsearch URL as input params #9760

LeeDr · 2017-01-06T01:16:18Z

This will allow running Kibana tests against and Elasticsearch and Kibana instance like;

Usage:
TEST_ES_URL=<protocol>://<username>:<password>@<host>:<port>  TEST_KIBANA_URL=<protocol>://<username>:<password>@<host>:<port> npm run test:ui:runner


Example:
TEST_ES_URL=https://elastic:changeme@localhost:9201  TEST_KIBANA_URL=https://elastic:changeme@localhost:9201 npm run test:ui:runner

And also still supports individual parameters like;

TEST_ES_PORT=9220 npm run test:ui:runner

jbudz · 2018-03-30T18:59:00Z

@LeeDr is this still WIP? Can we close it out?

elasticmachine · 2018-03-30T19:22:43Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

LeeDr · 2018-03-30T20:22:42Z

Oops. This slipped out of my radar. Yes, this would still be good to get in as we are driving to run kibana tests on Cloud. I'll rebase and get this going again.

elasticmachine · 2018-04-02T17:38:01Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

LeeDr · 2018-04-02T17:54:09Z

jenkins test this

elasticmachine · 2018-04-02T18:45:36Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

rhoboat · 2018-04-04T16:40:02Z

src/test_utils/es/es_test_config.js

+      port: testEsPort,
+      auth: testEsUsername + ':' + testEsPassword,
+      username: testEsUsername,
+      password: testEsPassword,


Is there any risk in doing:

getUrlParts() { let protocol; let hostname; let port; let auth; let username; let password; if (process.env.TEST_ES_URL) { // Allow setting one complete TEST_ES_URL for Es like // https://elastic:changeme@myCloudInstance:9200 const testEsUrl = url.parse(process.env.TEST_ES_URL); // have to remove the ":" off protocol protocol = testEsUrl.protocol.slice(0, -1); hostname = testEsUrl.hostname; port = parseInt(testEsUrl.port, 10); username = testEsUrl.username; password = testEsUrl.password; } else { // Allow setting any individual component(s) of the URL, // or use default values (username and password from shield.js) protocol = process.env.TEST_ES_PROTOCOL || 'http'; hostname = process.env.TEST_ES_HOSTNAME || 'localhost'; port = parseInt(process.env.TEST_ES_PORT, 10) || 9220; username = process.env.TEST_ES_USERNAME || admin.username; password = process.env.TEST_ES_PASSWORD || admin.password; } console.log(protocol); return { protocol, hostname, port, auth: `${username}:${password}`, username, password, }; }

(edited: removed too much first time)

rhoboat · 2018-04-04T16:47:07Z

test/kibana_test_server_url_parts.js

+  port: testKibanaPort,
+  username: testKibanaUsername,
+  password: testKibanaPassword,
+  auth: `${testKibanaUsername}:${testKibanaPassword}`


import { kibanaUser } from './shield'; import url from 'url'; let protocol; let hostname; let port; let username; let password; let auth; // Allow setting one complete TEST_KIBANA_URL for Kibana like // https://elastic:changeme@myCloudInstance:5601 if (process.env.TEST_KIBANA_URL) { const testKibanaUrl = url.parse(process.env.TEST_KIBANA_URL); // have to remove the ":" off protocol protocol = testKibanaUrl.protocol.slice(0, -1); hostname = testKibanaUrl.hostname; port = parseInt(testKibanaUrl.port, 10); username = testKibanaUrl.username; password = testKibanaUrl.password; } else { // Allow setting any individual component(s) of the URL, // or use default values (username and password from shield.js) protocol = process.env.TEST_KIBANA_PROTOCOL || 'http'; hostname = process.env.TEST_KIBANA_HOSTNAME || 'localhost'; port = parseInt(process.env.TEST_KIBANA_PORT, 10) || 5620; username = process.env.TEST_KIBANA_USERNAME || kibanaUser.username; password = process.env.TEST_KIBANA_PASSWORD || kibanaUser.password; } export const kibanaTestServerUrlParts = { protocol, hostname, port, auth: `${username}:${password}`, username, password, };

maybe make things more consistent with the ES file, too.

Thanks for the suggestion! I made that change and it is cleaner.

rhoboat · 2018-04-04T16:49:57Z

src/test_utils/es/es_test_config.js

+      testEsUsername = process.env.TEST_ES_USERNAME || admin.username;
+      testEsPassword = process.env.TEST_ES_PASSWORD || admin.password;
+    }
+    console.log(testEsProtocol);


remove these console.logs

rhoboat

LGTM, with some minor suggestions.

elasticmachine · 2018-04-04T17:17:18Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-04-04T19:24:29Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

tylersmalley · 2018-04-04T20:09:00Z

src/test_utils/es/es_test_config.js

+    let password;
+
+    // Allow setting one complete TEST_ES_URL for Es like https://elastic:changeme@myCloudInstance:9200
+    if (process.env.TEST_ES_URL) {


Can we just return an object here if TEST_ES_URL is defined? Then we can get rid of all the variables and last return.

getUrlParts() { // allow setting one complete TEST_ES_URL for ES like https://elastic:[email protected]:9200 if (process.env.TEST_ES_URL) { const testEsUrl = url.parse(process.env.TEST_ES_URL); return { ...testEsUrl, port: parseInt(testEsUrl.port, 10), auth: `${testEsUrl.username}:${testEsUrl.password}`, testEsUrl.protocol.slice(0, -1), }; } const username = process.env.TEST_ES_USERNAME || admin.username; const password = process.env.TEST_ES_PASSWORD || admin.password; return { protocol: process.env.TEST_ES_PROTOCOL || 'http', hostname: process.env.TEST_ES_HOSTNAME || 'localhost', port: parseInt(process.env.TEST_ES_PORT, 10) || 9220, auth: `${username}:${password}`, username, password, }; }

That sounds pretty good. I'll try it that way.

I'm not sure if I can do that for both the kibana and elasticsearch files;

For Kibana:

import { kibanaUser } from './shield'; import url from 'url'; function getUrlParts() { // allow setting one complete TEST_KIBANA_URL for ES like https://elastic:[email protected]:9200 if (process.env.TEST_KIBANA_URL) { const testKibanaUrl = url.parse(process.env.TEST_KIBANA_URL); return { ...testKibanaUrl, port: parseInt(testKibanaUrl.port, 10), auth: `${testKibanaUrl.username}:${testKibanaUrl.password}`, protocol: testKibanaUrl.protocol.slice(0, -1), }; } const username = process.env.TEST_KIBANA_USERNAME || kibanaUser.username; const password = process.env.TEST_KIBANA_PASSWORD || kibanaUser.password; return { protocol: process.env.TEST_KIBANA_PROTOCOL || 'http', hostname: process.env.TEST_KIBANA_HOSTNAME || 'localhost', port: parseInt(process.env.TEST_KIBANA_PORT, 10) || 9220, auth: `${username}:${password}`, username, password, }; } export const kibanaTestServerUrlParts = getUrlParts();

tylersmalley · 2018-04-04T20:15:44Z

src/test_utils/es/es_test_config.js

+    } else {
+      // Allow setting any individual component(s) of the URL,
+      // or use default values (username and password from shield.js)
+      protocol = process.env.TEST_ES_PROTOCOL || 'http';


Do you still need/use the other TEST_ES_* environment variables? Can we get rid of them if we are now providing the full URL?

I didn't want to break backward compatibility if anybody was just overriding a port or something like that. I don't know if anybody is using any of them, but they were documented.

tylersmalley · 2018-04-06T17:18:21Z

src/test_utils/es/es_test_config.js

+    let password;
+
+    // Allow setting one complete TEST_ES_URL for Es like https://elastic:changeme@myCloudInstance:9200
+    if (process.env.TEST_ES_URL) {


For Kibana:

import { kibanaUser } from './shield'; import url from 'url'; function getUrlParts() { // allow setting one complete TEST_KIBANA_URL for ES like https://elastic:[email protected]:9200 if (process.env.TEST_KIBANA_URL) { const testKibanaUrl = url.parse(process.env.TEST_KIBANA_URL); return { ...testKibanaUrl, port: parseInt(testKibanaUrl.port, 10), auth: `${testKibanaUrl.username}:${testKibanaUrl.password}`, protocol: testKibanaUrl.protocol.slice(0, -1), }; } const username = process.env.TEST_KIBANA_USERNAME || kibanaUser.username; const password = process.env.TEST_KIBANA_PASSWORD || kibanaUser.password; return { protocol: process.env.TEST_KIBANA_PROTOCOL || 'http', hostname: process.env.TEST_KIBANA_HOSTNAME || 'localhost', port: parseInt(process.env.TEST_KIBANA_PORT, 10) || 9220, auth: `${username}:${password}`, username, password, }; } export const kibanaTestServerUrlParts = getUrlParts();

elasticmachine · 2018-04-11T23:11:55Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

LeeDr · 2018-04-12T17:21:56Z

jenkins test this

elasticmachine · 2018-04-12T17:41:21Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-04-12T20:07:39Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

LeeDr · 2018-04-12T21:18:31Z

I've never seen this failure before where it logged page crashed and tab crashed;

20:04:18        │ debg  navigate to: http://localhost:5620/app/kibana#/discover
20:04:18        │ debg  --- tryForTime failure: [POST http://localhost:9515/session/fc612b86f34d294859f63706fa2c6386/url / {"url":"http://localhost:5620/app/kibana?_t=1523563458134#/discover"}] unknown error: session deleted because of page crash
20:04:18        │       from unknown error: cannot determine loading status
20:04:18        │       from tab crashed
20:04:18        │         (Session info: chrome=65.0.3325.162)
20:04:18        │         (Driver info: chromedriver=2.36.540471 (9c759b81a907e70363c6312294d30b6ccccc2752),platform=Linux 4.4.0-1044-aws x86_64)

LeeDr · 2018-04-12T21:18:38Z

jenkins test this

elasticmachine · 2018-04-12T22:10:39Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

LeeDr · 2018-04-12T22:13:19Z

@tylersmalley would you please check the latest commits and see if you're good with it?

tylersmalley · 2018-04-12T23:04:29Z

@LeeDr did you want to update the ES part, or keep as is?

LeeDr · 2018-04-13T13:58:35Z

@tylersmalley oops, yes, testing that change now...

elasticmachine · 2018-04-13T14:38:44Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

…sting

LeeDr · 2018-04-13T16:07:39Z

jenkins test this

…sting

elasticmachine · 2018-04-13T17:02:05Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

…sting

elasticmachine · 2018-04-13T18:05:00Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

LeeDr · 2018-04-13T18:17:49Z

Unrelated timelion test failure which needs some fix;

18:02:36            │ debg  in findAllByCssSelector: .suggestions .suggestion

18:02:37          └- ✖ fail: "timelion app expression typeahead dynamic suggestions for argument values .es() should show field suggestions for split argument when index pattern set"

18:02:37          │        [POST http://localhost:9515/session/39e692cd16e72c40c9f84f0aa2516bca/element/0.3484768890432888-38/click] stale element reference: element is not attached to the page document

LeeDr · 2018-04-13T18:17:57Z

jenkins test this

elasticmachine · 2018-04-13T19:07:50Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

LeeDr · 2018-04-13T19:20:01Z

@tylersmalley back to you. I made es_test_config.js similar to kibana_test_server_url_parts.js

* Support 1 Kibana and 1 Elasticsearch URL as input params * Revert a previous change to test char substitution * Allow setting TEST_KIBANA_URL and TEST_ES_URL for Cloud testing * cleanup comment * Update docs * Refactor after PR review * Changes from review * fix default Kibana port to 5620 * Change es_test_config.js similar to kibana_test_server_url_parts.js

) * Support 1 Kibana and 1 Elasticsearch URL as input params * Revert a previous change to test char substitution * Allow setting TEST_KIBANA_URL and TEST_ES_URL for Cloud testing * cleanup comment * Update docs * Refactor after PR review * Changes from review * fix default Kibana port to 5620 * Change es_test_config.js similar to kibana_test_server_url_parts.js

Support 1 Kibana and 1 Elasticsearch URL as input params

c42e8b8

LeeDr added the test label Jan 6, 2017

LeeDr mentioned this pull request Jan 25, 2017

NPM test should accept an Elasticsearch URL #6320

Closed

LeeDr added 5 commits April 2, 2018 11:07

Revert a previous change to test char substitution

96f33d0

merge

2427894

Allow setting TEST_KIBANA_URL and TEST_ES_URL for Cloud testing

693f64b

Merge branch 'master' into enableCloudTesting

ea9d912

cleanup comment

9629bcc

LeeDr requested a review from jbudz April 2, 2018 19:21

LeeDr changed the title ~~[WIP] Support 1 Kibana and 1 Elasticsearch URL as input params~~ Support 1 Kibana and 1 Elasticsearch URL as input params Apr 2, 2018

LeeDr added the review label Apr 2, 2018

LeeDr requested a review from rhoboat April 2, 2018 19:23

LeeDr mentioned this pull request Apr 3, 2018

Run Kibana tests on Cloud meta issue #17525

Closed

8 tasks

Update docs

8917742

rhoboat reviewed Apr 4, 2018

View reviewed changes

rhoboat approved these changes Apr 4, 2018

View reviewed changes

Refactor after PR review

7cdc0f7

tylersmalley reviewed Apr 4, 2018

View reviewed changes

tylersmalley suggested changes Apr 10, 2018

View reviewed changes

fix default Kibana port to 5620

5da1635

Change es_test_config.js similar to kibana_test_server_url_parts.js

a1fa8f8

Merge branch 'master' of github.com:elastic/kibana into enableCloudTe…

e03f5bf

…sting

Merge branch 'master' of github.com:elastic/kibana into enableCloudTe…

456134e

…sting

Merge branch 'master' of github.com:elastic/kibana into enableCloudTe…

97b4bbd

…sting

LeeDr added v7.0.0 v6.3.0 labels Apr 13, 2018

tylersmalley approved these changes Apr 18, 2018

View reviewed changes

LeeDr merged commit 842ed48 into elastic:master Apr 18, 2018

LeeDr deleted the enableCloudTesting branch August 20, 2020 17:53

Support 1 Kibana and 1 Elasticsearch URL as input params #9760

Support 1 Kibana and 1 Elasticsearch URL as input params #9760

Conversation

LeeDr commented Jan 6, 2017 • edited Loading

jbudz commented Mar 30, 2018

elasticmachine commented Mar 30, 2018

💔 Build Failed

LeeDr commented Mar 30, 2018

elasticmachine commented Apr 2, 2018

💔 Build Failed

LeeDr commented Apr 2, 2018

elasticmachine commented Apr 2, 2018

💚 Build Succeeded

rhoboat Apr 4, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rhoboat left a comment

Choose a reason for hiding this comment

elasticmachine commented Apr 4, 2018

💚 Build Succeeded

elasticmachine commented Apr 4, 2018

💚 Build Succeeded

Choose a reason for hiding this comment

tylersmalley Apr 4, 2018 • edited by rhoboat Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

elasticmachine commented Apr 11, 2018

💔 Build Failed

LeeDr commented Apr 12, 2018

elasticmachine commented Apr 12, 2018

💔 Build Failed

elasticmachine commented Apr 12, 2018

💔 Build Failed

LeeDr commented Apr 12, 2018

LeeDr commented Apr 12, 2018

elasticmachine commented Apr 12, 2018

💚 Build Succeeded

LeeDr commented Apr 12, 2018

tylersmalley commented Apr 12, 2018

LeeDr commented Apr 13, 2018

elasticmachine commented Apr 13, 2018

💔 Build Failed

LeeDr commented Apr 13, 2018

elasticmachine commented Apr 13, 2018

💔 Build Failed

elasticmachine commented Apr 13, 2018

💔 Build Failed

LeeDr commented Apr 13, 2018

LeeDr commented Apr 13, 2018

elasticmachine commented Apr 13, 2018

💚 Build Succeeded

LeeDr commented Apr 13, 2018

LeeDr commented Jan 6, 2017 •

edited

Loading

rhoboat Apr 4, 2018 •

edited

Loading

tylersmalley Apr 4, 2018 •

edited by rhoboat

Loading