Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [Security Solution] Fixes Exit full screen and Copy to cliboard styling issues (#96676) #97047

Merged

Conversation

andrew-goldstein
Copy link
Contributor

Backports the following commits to 7.x:

…` styling issues (elastic#96676)

## [Security Solution] Fixes `Exit full screen` and `Copy to clipboard` styling issues

Note: This PR is `release_note:skip` because the styling issues below do not effect any previous release.

- Fixes issue elastic#96209 where the `Exit full screen` button in Timeline's `Pinned` tab is rendered adjacent to, instead of above, the table:

### Before: Exit Full Screen (`Pinned` tab)

![exit-full-screen-before](https://user-images.githubusercontent.com/4459398/114104665-89372980-9888-11eb-9158-ffa9c5a5ce17.png)

_Before: The `Exit full screen` button on Timeline's `Pinned` tab_

### After: Exit Full Screen (`Pinned` tab)

![exit-full-screen-after](https://user-images.githubusercontent.com/4459398/114106055-3743d300-988b-11eb-9c4d-c08679702d05.png)

_After: The `Exit full screen` button on Timeline's `Pinned` tab_

- Fixes an issue where the `Copy to clipboard` hover menu action was not aligned with the other hover menu actions:

### Before: Copy to clipboard hover action

![copy-to-clipboard-before](https://user-images.githubusercontent.com/4459398/114106138-5c384600-988b-11eb-942e-ae4e09848b09.png)

_Before: The `Copy to clipboard` hover action was not aligned_

### After: Copy to clipboard hover action

![copy-to-clipboard-after](https://user-images.githubusercontent.com/4459398/114106236-8db11180-988b-11eb-85ae-476ac6d1df4e.png)

_After: The `Copy to clipboard` hover action is aligned_

### Desk Testing

Desk tested in:

- Chrome `89.0.4389.114`
- Firefox `87.0`
- Safari `14.0.3`
@andrew-goldstein andrew-goldstein enabled auto-merge (squash) April 13, 2021 21:04
@andrew-goldstein andrew-goldstein changed the title [7.x] ## [Security Solution] Fixes Exit full screen and Copy to cliboard styling issues (#96676) [7.x] [Security Solution] Fixes Exit full screen and Copy to cliboard styling issues (#96676) Apr 13, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 7.3MB 7.3MB -909.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants