Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] "Exit Full Screen" button is getting displaced to extreme top left corner under 'Pinned tab' of any Timeline. #96209

Closed
ghost opened this issue Apr 5, 2021 · 10 comments
Closed

[Security Solution] "Exit Full Screen" button is getting displaced to extreme top left corner under 'Pinned tab' of any Timeline. #96209

ghost opened this issue Apr 5, 2021 · 10 comments
Assignees
@andrew-goldstein
Labels
bug Fixes for quality problems that affect the customer experience fixed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team v7.13.0

Comments

@ghost
Copy link

ghost commented Apr 5, 2021

Description:
"Exit Full Screen" button is getting displaced to extreme top left corner under 'Pinned tab' of any Timeline.

Build Details:
Version: 7.13.0-Snapshot Build
Build: 39703
Commit: c0c6272
Artifacts: https://artifacts-api.elastic.co/v1/search/7.13.0-SNAPSHOT

Browser Details:
All

Preconditions:

  • Kibana Environment should exist.
  • Endpoint security should be installed
  • Pinned event should exist under Pinned Tab of any timeline

Steps to Reproduce:

  1. Navigate to 'Timeline' tab of security.
  2. Create a timeline by clicking on 'Create New Timeline' button
  3. Now, click on pin icon and mark few events as pinned. Notice, that pinned events are now getting reflected under 'Pinned Tab'
  4. Switch to 'Pinned' tab and click on 'Full Screen' icon
  5. Observe that Exit Full Screen button is getting displaced to left top corner.

Impacted Test case:
N/A

Actual Result:
"Exit Full Screen" button is getting displaced to extreme top left corner under 'Pinned tab' of any Timeline.

Expected Result:
"Exit Full Screen" button should be displayed on the top of events table in Full screen mode.

What's working:
This issue is not occurring for other tabs like Query Table, Correlation, Analyzer etc.

What's not working:
This issue is occurring for only in 'Pinned' tabs of Timeline

Exit_Full+_Screen
@ghost ghost added bug Fixes for quality problems that affect the customer experience Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. labels Apr 5, 2021
@manishgupta-qasource
Copy link

Reviewed & assigned to @MadameSheema

@manishgupta-qasource manishgupta-qasource added impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. 7.13 candidate labels Apr 5, 2021
@MadameSheema MadameSheema added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. triage_needed Team:Threat Hunting Security Solution Threat Hunting Team and removed 7.13 candidate impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. labels Apr 6, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@MadameSheema
Copy link
Member

@XavierM can you please take a look at this? Thanks :)

@MadameSheema
Copy link
Member

@mandeepkaur-qasource can you please check if this is happening on 7.12.x as well? Thanks :)

@MadameSheema MadameSheema removed their assignment Apr 7, 2021
@ghost
Copy link
Author

ghost commented Apr 8, 2021

Hi Team,

I have cross checked the UI for "Exit Full Screen" button under 'Pinned' Tab on 7.12.0 cloud build and observed that "Exit Full Screen" button is correctly getting displayed on the Top of the table. Please refer attached screen shot:

7 12 0_UI_Pinned Tab

andrew-goldstein added a commit to andrew-goldstein/kibana that referenced this issue Apr 8, 2021
@andrew-goldstein
## [Security Solution] Fixes Exit full screen and `Copy to cliboard…
d0877bc 
…` styling issues

Note: This PR is `release_note:skip` because the styling issues below do not effect any previous release.

- Fixes an issue elastic#96209 where the `Exit full screen` button in Timeline's `Pinned` tab is rendered adjacent to, instead of above, the table:

### Before: Exit Full Screen (`Pinned` tab)

![exit-full-screen-before](https://user-images.githubusercontent.com/4459398/114104665-89372980-9888-11eb-9158-ffa9c5a5ce17.png)

_Before: The `Exit full screen` button on Timeline's `Pinned` tab_

### After: Exit Full Screen (`Pinned` tab)

![exit-full-screen-after](https://user-images.githubusercontent.com/4459398/114106055-3743d300-988b-11eb-9c4d-c08679702d05.png)

_After: The `Exit full screen` button on Timeline's `Pinned` tab_

- Fixes an issue where the `Copy to clipboard` hover menu action was not aligned with the other hover menu actions:

### Before: Copy to clipboard hover action

![copy-to-clipboard-before](https://user-images.githubusercontent.com/4459398/114106138-5c384600-988b-11eb-942e-ae4e09848b09.png)

_Before: The `Copy to clipboard` hover action was not aligned_

### After: Copy to clipboard hover action

![copy-to-clipboard-after](https://user-images.githubusercontent.com/4459398/114106236-8db11180-988b-11eb-85ae-476ac6d1df4e.png)

_After: The `Copy to clipboard` hover action is aligned_

### Desk Testing

Desk tested in:

- Chrome `89.0.4389.114`
- Firefox `87.0`
- Safari `14.0.3`
@andrew-goldstein andrew-goldstein mentioned this issue Apr 8, 2021
Merged
andrew-goldstein added a commit that referenced this issue Apr 13, 2021
@andrew-goldstein
## [Security Solution] Fixes Exit full screen and `Copy to cliboard…
a66bb53 
…` styling issues (#96676)

## [Security Solution] Fixes `Exit full screen` and `Copy to clipboard` styling issues

Note: This PR is `release_note:skip` because the styling issues below do not effect any previous release.

- Fixes issue #96209 where the `Exit full screen` button in Timeline's `Pinned` tab is rendered adjacent to, instead of above, the table:

### Before: Exit Full Screen (`Pinned` tab)

![exit-full-screen-before](https://user-images.githubusercontent.com/4459398/114104665-89372980-9888-11eb-9158-ffa9c5a5ce17.png)

_Before: The `Exit full screen` button on Timeline's `Pinned` tab_

### After: Exit Full Screen (`Pinned` tab)

![exit-full-screen-after](https://user-images.githubusercontent.com/4459398/114106055-3743d300-988b-11eb-9c4d-c08679702d05.png)

_After: The `Exit full screen` button on Timeline's `Pinned` tab_

- Fixes an issue where the `Copy to clipboard` hover menu action was not aligned with the other hover menu actions:

### Before: Copy to clipboard hover action

![copy-to-clipboard-before](https://user-images.githubusercontent.com/4459398/114106138-5c384600-988b-11eb-942e-ae4e09848b09.png)

_Before: The `Copy to clipboard` hover action was not aligned_

### After: Copy to clipboard hover action

![copy-to-clipboard-after](https://user-images.githubusercontent.com/4459398/114106236-8db11180-988b-11eb-85ae-476ac6d1df4e.png)

_After: The `Copy to clipboard` hover action is aligned_

### Desk Testing

Desk tested in:

- Chrome `89.0.4389.114`
- Firefox `87.0`
- Safari `14.0.3`
andrew-goldstein added a commit to andrew-goldstein/kibana that referenced this issue Apr 13, 2021
@andrew-goldstein
## [Security Solution] Fixes Exit full screen and `Copy to cliboard…
1c781bb 
…` styling issues (elastic#96676)

## [Security Solution] Fixes `Exit full screen` and `Copy to clipboard` styling issues

Note: This PR is `release_note:skip` because the styling issues below do not effect any previous release.

- Fixes issue elastic#96209 where the `Exit full screen` button in Timeline's `Pinned` tab is rendered adjacent to, instead of above, the table:

### Before: Exit Full Screen (`Pinned` tab)

![exit-full-screen-before](https://user-images.githubusercontent.com/4459398/114104665-89372980-9888-11eb-9158-ffa9c5a5ce17.png)

_Before: The `Exit full screen` button on Timeline's `Pinned` tab_

### After: Exit Full Screen (`Pinned` tab)

![exit-full-screen-after](https://user-images.githubusercontent.com/4459398/114106055-3743d300-988b-11eb-9c4d-c08679702d05.png)

_After: The `Exit full screen` button on Timeline's `Pinned` tab_

- Fixes an issue where the `Copy to clipboard` hover menu action was not aligned with the other hover menu actions:

### Before: Copy to clipboard hover action

![copy-to-clipboard-before](https://user-images.githubusercontent.com/4459398/114106138-5c384600-988b-11eb-942e-ae4e09848b09.png)

_Before: The `Copy to clipboard` hover action was not aligned_

### After: Copy to clipboard hover action

![copy-to-clipboard-after](https://user-images.githubusercontent.com/4459398/114106236-8db11180-988b-11eb-85ae-476ac6d1df4e.png)

_After: The `Copy to clipboard` hover action is aligned_

### Desk Testing

Desk tested in:

- Chrome `89.0.4389.114`
- Firefox `87.0`
- Safari `14.0.3`
andrew-goldstein added a commit that referenced this issue Apr 13, 2021
@andrew-goldstein
## [Security Solution] Fixes Exit full screen and `Copy to cliboard…
d51c966 
…` styling issues (#96676) (#97047)

## [Security Solution] Fixes `Exit full screen` and `Copy to clipboard` styling issues

Note: This PR is `release_note:skip` because the styling issues below do not effect any previous release.

- Fixes issue #96209 where the `Exit full screen` button in Timeline's `Pinned` tab is rendered adjacent to, instead of above, the table:

### Before: Exit Full Screen (`Pinned` tab)

![exit-full-screen-before](https://user-images.githubusercontent.com/4459398/114104665-89372980-9888-11eb-9158-ffa9c5a5ce17.png)

_Before: The `Exit full screen` button on Timeline's `Pinned` tab_

### After: Exit Full Screen (`Pinned` tab)

![exit-full-screen-after](https://user-images.githubusercontent.com/4459398/114106055-3743d300-988b-11eb-9c4d-c08679702d05.png)

_After: The `Exit full screen` button on Timeline's `Pinned` tab_

- Fixes an issue where the `Copy to clipboard` hover menu action was not aligned with the other hover menu actions:

### Before: Copy to clipboard hover action

![copy-to-clipboard-before](https://user-images.githubusercontent.com/4459398/114106138-5c384600-988b-11eb-942e-ae4e09848b09.png)

_Before: The `Copy to clipboard` hover action was not aligned_

### After: Copy to clipboard hover action

![copy-to-clipboard-after](https://user-images.githubusercontent.com/4459398/114106236-8db11180-988b-11eb-85ae-476ac6d1df4e.png)

_After: The `Copy to clipboard` hover action is aligned_

### Desk Testing

Desk tested in:

- Chrome `89.0.4389.114`
- Firefox `87.0`
- Safari `14.0.3`
@andrew-goldstein
Copy link
Contributor

Fixed by:

@MadameSheema
Copy link
Member

@mandeepkaur-qasource can you please validate the fix of this issue on the first 7.13BC? Thanks :)

@MadameSheema
Copy link
Member

@karanbirsingh-qasource as Mandeep is out sick, can you please validate this ticket on the latest 7.13.0BC? Thanks :)

@ghost
Copy link

ghost commented Apr 28, 2021

Hi @MadameSheema,

We have validated this ticket on 7.13.0 BC3 build and observed that issue is fixed. "Exit Full Screen" button is displayed on the top of events table in Full screen mode.

Build Details:

Version:7.13.0 BC3
Commit:ac09c73a4a7998c770b50d39177c22036ae14375
Build:40647

Screenshot:
Pinned_screen

Hence, We are closing this ticket and adding the "QA validated" label.

Thanks!!

@ghost ghost added the QA:Validated Issue has been validated by QA label Apr 28, 2021
@ghost ghost closed this as completed Apr 28, 2021
@ghost
Copy link
Author

ghost commented Jun 9, 2021

Bug Conversion:

Updated existing test case for ticket:

https://elastic.testrail.io/index.php?/cases/view/34966

Thanks!!

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrew-goldstein andrew-goldstein

Labels
bug Fixes for quality problems that affect the customer experience fixed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team v7.13.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@XavierM @andrew-goldstein @elasticmachine @MadameSheema @manishgupta-qasource