Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Move fleet server indices creation out of Kibana #96338

Merged
merged 2 commits into from
Apr 7, 2021

Conversation

nchaulet
Copy link
Member

@nchaulet nchaulet commented Apr 6, 2021

Summary

Resolve #96327

Depends on elastic/elasticsearch#70689

Fleet server system indices .fleet-agents, ... are now created by ES instead of Kibana that PR make the change.
Also the indices are only created when we add a document so all the search call are now using ignore_unavailable:true

@nchaulet nchaulet added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.13.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Apr 6, 2021
@nchaulet nchaulet self-assigned this Apr 6, 2021
@nchaulet nchaulet requested a review from a team as a code owner April 6, 2021 17:21
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nchaulet

Copy link

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this with the latest elasticsearch snapshot and it worked.

Without this fleet-server is completely broken with latest elasticsearch snapshot.

@nchaulet nchaulet requested review from Zacqary and jen-huang April 7, 2021 16:54
Copy link
Contributor

@jen-huang jen-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM 👍🏻

@nchaulet nchaulet merged commit 22f7f17 into elastic:master Apr 7, 2021
@nchaulet nchaulet deleted the feature-es-create-indices branch April 7, 2021 17:07
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 7, 2021
@kibanamachine
Copy link
Contributor

💚 Backport successful

7.x / #96460

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.13.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fleet] Remove fleet server index creation
5 participants