Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update graceful handling for missing indices to accommodate the new fleet system indices plugin #205

Merged
merged 2 commits into from
Apr 7, 2021

Conversation

aleksmaus
Copy link
Contributor

What does this PR do?

Graceful handling for the case where the indices are not found.

Tested full stack with ES system indices plugin PR elastic/elasticsearch#70689
and kibana update for this elastic/kibana#96338 working end to end with osquerybeat.
Found issues where fleet server doesn't handle the case where the index doesn't exists.

The ES system indices plugin no longer creates the indices. The indices are now created when the first document is pushed, and the fleet server doesn't handle the missing index case gracefully (as some point before it did).

This change can be merged before the related tickets.

Why is it important?

This is important in order to adopt the fleet system indices plugin.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas

@elasticmachine
Copy link
Contributor

elasticmachine commented Apr 7, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #205 updated

  • Start Time: 2021-04-07T13:45:41.832+0000

  • Duration: 14 min 42 sec

  • Commit: a179016

Test stats 🧪

Test Results
Failed 0
Passed 66
Skipped 0
Total 66

Trends 🧪

Image of Build Times

Image of Tests

Copy link

@scunningham scunningham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we log something?

@aleksmaus aleksmaus merged commit 85d0ebf into elastic:master Apr 7, 2021
mergify bot pushed a commit that referenced this pull request Apr 13, 2021
…leet system indices plugin (#205)

* Update the no index found handling to accommodate the new fleet system indices plugin

* Add logging

(cherry picked from commit 85d0ebf)
mergify bot added a commit that referenced this pull request Apr 13, 2021
…leet system indices plugin (#205) (#231)

* Update the no index found handling to accommodate the new fleet system indices plugin

* Add logging

(cherry picked from commit 85d0ebf)

Co-authored-by: Aleksandr Maus <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants