Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [ML] Refactor imports using 'elasticsearch' to '@elastic/elasticsearch'. Extend 'isPopulatedOjbect()'. (#95651) #96058

Merged
merged 2 commits into from
Apr 1, 2021

Conversation

walterra
Copy link
Contributor

@walterra walterra commented Apr 1, 2021

Backports the following commits to 7.x:

…h'. Extend 'isPopulatedOjbect()'. (elastic#95651)

- Gets rid of imports from 'elasticsearch' and replaces them with '@elastic/elasticsearch'.
- Extends isPopulatedObject() to allow an optional array of attributes to check if they exist. Allows us to get rid of the manual and inconsistent usages of hasOwnProperty().
@walterra walterra enabled auto-merge (squash) April 1, 2021 15:15
@walterra walterra added the :ml label Apr 1, 2021
@walterra walterra self-assigned this Apr 1, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
ml 1779 1780 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 5.9MB 5.9MB +216.0B
transform 907.9KB 907.3KB -604.0B
total -388.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
ml 64.9KB 65.5KB +532.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @walterra

@walterra walterra merged commit 30744ee into elastic:7.x Apr 1, 2021
@walterra walterra deleted the backport/7.x/pr-95651 branch April 1, 2021 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants