Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [ML] Refactor imports using 'elasticsearch' to '@elastic/elasticsearch'. Extend 'isPopulatedOjbect()'. (#95651) #96027

Closed

Conversation

kibanamachine
Copy link
Contributor

Backports the following commits to 7.x:

…h'. Extend 'isPopulatedOjbect()'. (elastic#95651)

- Gets rid of imports from 'elasticsearch' and replaces them with '@elastic/elasticsearch'.
- Extends isPopulatedObject() to allow an optional array of attributes to check if they exist. Allows us to get rid of the manual and inconsistent usages of hasOwnProperty().
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@kibanamachine
Copy link
Contributor Author

💔 Build Failed

Failed CI Steps

Metrics [docs]

‼️ ERROR: metrics for 8a17898 were not reported

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @walterra

@walterra walterra closed this Apr 1, 2021
auto-merge was automatically disabled April 1, 2021 15:14

Pull request was closed

@walterra
Copy link
Contributor

walterra commented Apr 1, 2021

Not sure why that import was possible on master but fails on the backport. Trying again another backport triggered from the command line against my username so I can push a fix should it fail again here: #96058

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants