Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix brushing on small multiples #94505

Merged
merged 2 commits into from
Mar 15, 2021
Merged

Fix brushing on small multiples #94505

merged 2 commits into from
Mar 15, 2021

Conversation

nickofthyme
Copy link
Contributor

@nickofthyme nickofthyme commented Mar 11, 2021 •
edited
Loading

Summary

fixes #94252

Upgrade to charts fixes a few bugs and adds features. See https://github.com/elastic/elastic-charts/releases

Screen.Recording.2021-03-11.at.04.51.36.PM.mp4

Checklist

@nickofthyme nickofthyme added dependencies Pull requests that update a dependency file release_note:skip Skip the PR/issue when compiling release notes v7.12.0 v7.13.0 v8.0.0 labels Mar 11, 2021
@nickofthyme nickofthyme changed the title Upgrade charts to 25.3.0 Fix brushing on small multiples Mar 11, 2021
@nickofthyme nickofthyme requested a review from bhavyarm March 11, 2021 23:30
@nickofthyme nickofthyme mentioned this pull request Mar 11, 2021
Merged
1 task
@nickofthyme nickofthyme requested a review from markov00 March 12, 2021 00:35
markov00
markov00 approved these changes Mar 15, 2021
View reviewed changes
Copy link
Member

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bhavyarm
bhavyarm approved these changes Mar 15, 2021
View reviewed changes
Copy link
Contributor

@bhavyarm bhavyarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @markov00 @nickofthyme

@nickofthyme
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

@kbn/ui-shared-deps asset size

id before after diff
[email protected] 2.5MB 2.5MB +6.2KB
kbn-ui-shared-deps.js 7.4MB 7.4MB +6.0B
total +6.2KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nickofthyme nickofthyme merged commit 2bfba7b into elastic:master Mar 15, 2021
@nickofthyme nickofthyme deleted the upgrade-charts branch March 15, 2021 17:25
@nickofthyme nickofthyme mentioned this pull request Mar 15, 2021
Merged
nickofthyme added a commit that referenced this pull request Mar 15, 2021
@nickofthyme
fix brushing on small multiples (#94505) (#94611)
cd0a970 
# Conflicts:
#	renovate.json5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhavyarm bhavyarm bhavyarm approved these changes

@markov00 markov00 markov00 approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file release_note:skip Skip the PR/issue when compiling release notes v7.13.0 v8.0.0
Projects
None yet
Milestone
No milestone
4 participants
@nickofthyme @kibanamachine @markov00 @bhavyarm