Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Settings: Update layout and update/add descriptions #94398

Merged
merged 17 commits into from
Mar 16, 2021
Merged

[APM] Settings: Update layout and update/add descriptions #94398

merged 17 commits into from
Mar 16, 2021

Conversation

formgeist
Copy link
Contributor

Summary

Closes #71074

Updated styles and added descriptions to improve the layout and content across the four settings views.

2021-03-11 at 9 19 36 - Ivory Catshark

@formgeist formgeist added Team:APM All issues that need APM UI Team support v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.13.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Mar 11, 2021
@formgeist formgeist self-assigned this Mar 11, 2021
@formgeist formgeist requested a review from a team as a code owner March 11, 2021 08:30
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@formgeist formgeist requested a review from bmorelli25 March 11, 2021 08:30
sorenlouv
sorenlouv approved these changes Mar 15, 2021
View reviewed changes
Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for doing this @formgeist !

@formgeist
Copy link
Contributor Author

@elasticmachine merge upstream

@bmorelli25
Copy link
Member

bmorelli25 commented Mar 16, 2021 •
edited
Loading

Should we also consider updating the empty state text for agent configuration? For example, we'll be adding the following text to the page:

This allows you to fine-tune your agent configuration from within the APM app. Changes are automatically propagated to your APM agents, so there’s no need to redeploy.

The empty state text already says something very similar:

No configurations found.
Let's change that! You can fine-tune agent configuration directly from Kibana without having to redeploy. Get started by creating your first configuration.

I think we could completely remove the empty state text (leaving only No configurations found) to avoid this duplication.

@formgeist
Copy link
Contributor Author

Should we also consider updating the empty state text for agent configuration? For example, we'll be adding the following text to the page:

This allows you to fine-tune your agent configuration from within the APM app. Changes are automatically propagated to your APM agents, so there’s no need to redeploy.

The empty state text already says something very similar:

No configurations found.
Let's change that! You can fine-tune agent configuration directly from Kibana without having to redeploy. Get started by creating your first configuration.

I think we could completely remove the empty state text (leaving only No configurations found) to avoid this duplication.

Good catch! I agree - removed it in 5ba9113

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 5.3MB 5.3MB +584.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @formgeist

bmorelli25
bmorelli25 approved these changes Mar 16, 2021
View reviewed changes
Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@formgeist formgeist merged commit 70bdb28 into elastic:master Mar 16, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Mar 16, 2021
@formgeist @kibanamachine @bmorelli25
[APM] Settings: Update layout and update/add descriptions (elastic#94398
e3052ff 
)

* [APM] Align naming

* [APM] Add agent config description

* [APM] Update layout and styles

* [APM] Update text styles and spacing

* [APM] Updating styles and layout

* [APM] Update layout and styles

* [APM] Update description

* [APM] Update layout and styles

* [APM] Update i18n name

* [APM] Add i18n description

* [APM] Update layout and styles

* Update x-pack/plugins/apm/public/components/app/Settings/CustomizeUI/index.tsx

Co-authored-by: Brandon Morelli <[email protected]>

* [APM] Update agent config description

* Update x-pack/plugins/apm/public/components/app/Settings/AgentConfigurations/index.tsx

Co-authored-by: Brandon Morelli <[email protected]>

* [APM] Remove empty state description

Not needed as we have a description by the main title

* [APM] Remove unneeded translations

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Brandon Morelli <[email protected]>
@kibanamachine kibanamachine mentioned this pull request Mar 16, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

✅ 7.x / #94743

Successful backport PRs will be merged automatically after passing CI.

@formgeist formgeist deleted the apm-update-settings-styles branch March 16, 2021 18:32
kibanamachine added a commit that referenced this pull request Mar 16, 2021
@kibanamachine @formgeist @bmorelli25
[APM] Settings: Update layout and update/add descriptions (#94398) (#…
4fd84d5 
…94743)

* [APM] Align naming

* [APM] Add agent config description

* [APM] Update layout and styles

* [APM] Update text styles and spacing

* [APM] Updating styles and layout

* [APM] Update layout and styles

* [APM] Update description

* [APM] Update layout and styles

* [APM] Update i18n name

* [APM] Add i18n description

* [APM] Update layout and styles

* Update x-pack/plugins/apm/public/components/app/Settings/CustomizeUI/index.tsx

Co-authored-by: Brandon Morelli <[email protected]>

* [APM] Update agent config description

* Update x-pack/plugins/apm/public/components/app/Settings/AgentConfigurations/index.tsx

Co-authored-by: Brandon Morelli <[email protected]>

* [APM] Remove empty state description

Not needed as we have a description by the main title

* [APM] Remove unneeded translations

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Brandon Morelli <[email protected]>

Co-authored-by: Casper Hübertz <[email protected]>
Co-authored-by: Brandon Morelli <[email protected]>
jloleysens added a commit that referenced this pull request Mar 17, 2021
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into ilm/rollup-v2…
29a96dd 
…-action

* 'master' of github.com:elastic/kibana: (44 commits)
  Migrate the optimizer mixin to core (#94272)
  Replace EuiCodeBlock with JsonCodeEditor in DiscoverGrid (#92442)
  [ML] Anomaly Detection: Migrate validation messages links to use docLinks. (#94568)
  [Lists][Exceptions] - Adding basic linting, i18n and storybook support (#94772)
  [Fleet] Add test/fix for invalid/missing ids in bulk agent reassign (#94632)
  [Security Solution] [Cases] Move create page components and dependencies to Cases (#94444)
  [ML] Data Frame Analytics accessibility tests: fix flaky outlier creation test (#94735)
  [Security Solutions] Remove commented out old linter rules (#94753)
  [App Search] Role mappings migration part 2 (#94461)
  [CI] Update Backport action inputs to match updated ones (#94721)
  [chore] Remove the infra team from CODEOWNERS (#94740)
  [Connectors UI] Make UI use new connector APIs (#94180)
  [ML] Use indices options in anomaly detection job wizards (#91830)
  Remove `string` as a valid registry var type value (#94174)
  [Alerts] Replaces legacy es client with the ElasticsearchClient for alerts and triggers_actions_ui plugins. (#93364)
  [Reporting-CSV Export] Re-write CSV Export using SearchSource (#88303)
  chore(NA): upgrade bazel rules nodejs to v3.2.2 (#94726)
  [APM] Settings: Update layout and update/add descriptions (#94398)
  skip flaky suite (#94666)
  [XY axis] Integrates legend color picker with the eui palette (#90589)
  ...

# Conflicts:
#	x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/cold_phase/cold_phase.tsx
#	x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/shared_fields/searchable_snapshot_field/searchable_snapshot_field.tsx
#	x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/constants.ts
#	x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/edit_policy.tsx
#	x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/form/configuration_context.tsx
#	x-pack/plugins/index_lifecycle_management/public/shared_imports.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmorelli25 bmorelli25 bmorelli25 approved these changes

@sorenlouv sorenlouv sorenlouv approved these changes

Assignees

@formgeist formgeist

Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v7.13.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM] Fix inconsistencies in APM Settings
5 participants
@formgeist @elasticmachine @bmorelli25 @kibanamachine @sorenlouv