[Alerts] Replaces legacy es client with the ElasticsearchClient for alerts and triggers_actions_ui plugins. #93364

YulNaumenko · 2021-03-03T03:46:38Z

Resolve #50247

Did the proper changes for the alerts plugin:

Removed dependencies on the legacy client
Removed callCluster from the list of available services
Replaced usage of callCluster: services.callCluster, with esClient: services.scopedClusterClient, in all alerting dependent plugins.
Fixed tests by adding elasticsearchClientMock.createScopedClusterClient()

elasticmachine · 2021-03-03T03:46:40Z

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

elasticmachine · 2021-03-06T02:22:58Z

Pinging @elastic/apm-ui (Team:apm)

igoristic

I'm getting a lot of:

Alert "50cb60a0-80d4-11eb-aaaa-a502e7dca037" has resulted in Error: callCluster is not a function

This is because we need to also change any instance of

const response = await callCluster('search', params);`

in monitoring/server/lib/alerts/fetch*queries to:

const response = await callCluster.search(params);

Also, we still need to wrap the response promise (alert fetch queries) in mbSafeQuery in case they also have metricbeat-* indices, since it might break/block the UI under certain conditions

…re with IScopedClusterClient instead of ElasticsearchClient asCurrentUser

dhurley14 · 2021-03-15T19:15:40Z

x-pack/plugins/security_solution/server/lib/detection_engine/routes/index/get_index_version.ts

@@ -34,5 +34,5 @@ export const getIndexVersion = async (
    return 0;
  }
  const writeIndexMapping = await readIndex(esClient, writeIndex);
-  return get(writeIndexMapping, [writeIndex, 'mappings', '_meta', 'version']) ?? 0;
+  return get(writeIndexMapping, ['body', writeIndex, 'mappings', '_meta', 'version']) ?? 0;


elasticmachine · 2021-03-16T01:07:27Z

Pinging @elastic/uptime (Team:uptime)

shahzad31

Uptime changes LGTM !!

dhurley14

LGTM! Thanks for all the work to get the tests passing. Tested out running some rules locally and everything looked good 👍

igoristic

Stack Monitoring changes look good 👍 Thank you for adding this!

kibanamachine · 2021-03-16T18:45:54Z

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`stackAlerts`	682.6KB	682.6KB	+3.0B

History

💚 Build #113425 succeeded 51d6f30
💔 Build #113411 failed 7da1ae0
💛 Build #113273 was flaky 04aeeff
💔 Build #113254 failed e595e85
💔 Build #113266 failed c0ff617

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @YulNaumenko

…lerts and triggers_actions_ui plugins. (elastic#93364) * [Alerts] Replaces legasy es client with the ElasticsearchClient * fixed build * fixed build * fixed ci build * fixed ci build * fixed infra callCLuster * fixed infra callCLuster * fixed infra callCLuster * fixed ci build * fixed ci build * fixed ci build * fixed infra tests * fixed security tests * fixed security tests * fixed security tests * fixed tests * fixed monitoring unit tests * fixed monitoring unit tests * fixed type checks * fixed type checks * fixed type checks * migrated lists plugin * fixed type checks * fixed tests * fixed security tests * fixed type checks * fixed tests * fixed type checks * fixed tests * fixed tests * fixed tests * fixed due to comments * fixed tests * fixed comment * fixed tests * fixed tests * fixed searh * fixed searh * fixed test * fixed due to comment * fixed detections failing test and replaces scopedClusterClient exposure with IScopedClusterClient instead of ElasticsearchClient asCurrentUser * fixed test * fixed test * fixed test * fixed typecheck * fixed typecheck * fixed typecheck * fixed merge

… for alerts and triggers_actions_ui plugins. (#93364) (#94747) * [Alerts] Replaces legacy es client with the ElasticsearchClient for alerts and triggers_actions_ui plugins. (#93364) * [Alerts] Replaces legasy es client with the ElasticsearchClient * fixed build * fixed build * fixed ci build * fixed ci build * fixed infra callCLuster * fixed infra callCLuster * fixed infra callCLuster * fixed ci build * fixed ci build * fixed ci build * fixed infra tests * fixed security tests * fixed security tests * fixed security tests * fixed tests * fixed monitoring unit tests * fixed monitoring unit tests * fixed type checks * fixed type checks * fixed type checks * migrated lists plugin * fixed type checks * fixed tests * fixed security tests * fixed type checks * fixed tests * fixed type checks * fixed tests * fixed tests * fixed tests * fixed due to comments * fixed tests * fixed comment * fixed tests * fixed tests * fixed searh * fixed searh * fixed test * fixed due to comment * fixed detections failing test and replaces scopedClusterClient exposure with IScopedClusterClient instead of ElasticsearchClient asCurrentUser * fixed test * fixed test * fixed test * fixed typecheck * fixed typecheck * fixed typecheck * fixed merge * fixed merge issues

…-action * 'master' of github.com:elastic/kibana: (44 commits) Migrate the optimizer mixin to core (#94272) Replace EuiCodeBlock with JsonCodeEditor in DiscoverGrid (#92442) [ML] Anomaly Detection: Migrate validation messages links to use docLinks. (#94568) [Lists][Exceptions] - Adding basic linting, i18n and storybook support (#94772) [Fleet] Add test/fix for invalid/missing ids in bulk agent reassign (#94632) [Security Solution] [Cases] Move create page components and dependencies to Cases (#94444) [ML] Data Frame Analytics accessibility tests: fix flaky outlier creation test (#94735) [Security Solutions] Remove commented out old linter rules (#94753) [App Search] Role mappings migration part 2 (#94461) [CI] Update Backport action inputs to match updated ones (#94721) [chore] Remove the infra team from CODEOWNERS (#94740) [Connectors UI] Make UI use new connector APIs (#94180) [ML] Use indices options in anomaly detection job wizards (#91830) Remove `string` as a valid registry var type value (#94174) [Alerts] Replaces legacy es client with the ElasticsearchClient for alerts and triggers_actions_ui plugins. (#93364) [Reporting-CSV Export] Re-write CSV Export using SearchSource (#88303) chore(NA): upgrade bazel rules nodejs to v3.2.2 (#94726) [APM] Settings: Update layout and update/add descriptions (#94398) skip flaky suite (#94666) [XY axis] Integrates legend color picker with the eui palette (#90589) ... # Conflicts: # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/cold_phase/cold_phase.tsx # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/shared_fields/searchable_snapshot_field/searchable_snapshot_field.tsx # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/constants.ts # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/edit_policy.tsx # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/form/configuration_context.tsx # x-pack/plugins/index_lifecycle_management/public/shared_imports.ts

[Alerts] Replaces legasy es client with the ElasticsearchClient

58a1e61

YulNaumenko added Feature:Alerting v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.13.0 labels Mar 3, 2021

YulNaumenko self-assigned this Mar 3, 2021

YulNaumenko requested a review from a team as a code owner March 3, 2021 03:46

YulNaumenko changed the title ~~[Alerts] Replaces legasy es client with the ElasticsearchClient~~ [Alerts] Replaces legacy es client with the ElasticsearchClient for alerts plugin Mar 3, 2021

YulNaumenko added 5 commits March 2, 2021 21:43

fixed build

fe562d3

fixed build

b411fbd

fixed ci build

2e3b0ef

fixed ci build

8881c3b

fixed infra callCLuster

8e94717

YulNaumenko requested a review from a team as a code owner March 3, 2021 19:21

fixed infra callCLuster

2ecfc15

YulNaumenko requested a review from a team as a code owner March 3, 2021 19:26

YulNaumenko added 2 commits March 5, 2021 07:54

fixed infra callCLuster

86f5d4b

fixed ci build

29e64ef

YulNaumenko requested a review from a team as a code owner March 5, 2021 17:27

YulNaumenko added 3 commits March 5, 2021 09:29

Merge remote-tracking branch upstream/master

c458fe5

fixed ci build

4c9384b

fixed ci build

3163f20

YulNaumenko requested a review from a team as a code owner March 6, 2021 02:22

botelastic bot added the Team:APM All issues that need APM UI Team support label Mar 6, 2021

Merge remote-tracking branch upstream/master

4242b1e

YulNaumenko added 2 commits March 11, 2021 10:11

fixed test

a821b9a

fixed due to comment

694afbd

igoristic suggested changes Mar 15, 2021

View reviewed changes

YulNaumenko added 2 commits March 15, 2021 11:54

fixed detections failing test and replaces scopedClusterClient exposu…

3651f96

…re with IScopedClusterClient instead of ElasticsearchClient asCurrentUser

Merge remote-tracking branch upstream/master

97eaaf8

dhurley14 reviewed Mar 15, 2021

View reviewed changes

fixed test

e595e85

YulNaumenko requested a review from igoristic March 15, 2021 23:55

YulNaumenko added 2 commits March 15, 2021 17:57

fixed test

3acd943

fixed test

c0ff617

YulNaumenko requested a review from a team as a code owner March 16, 2021 01:07

botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Mar 16, 2021

YulNaumenko added 2 commits March 15, 2021 18:39

fixed typecheck

c62ab0c

fixed typecheck

04aeeff

shahzad31 approved these changes Mar 16, 2021

View reviewed changes

dhurley14 approved these changes Mar 16, 2021

View reviewed changes

igoristic approved these changes Mar 16, 2021

View reviewed changes

YulNaumenko added 3 commits March 16, 2021 08:59

Merge remote-tracking branch upstream/master

7da1ae0

fixed typecheck

51d6f30

fixed merge

d7947f9

YulNaumenko merged commit 21587dc into elastic:master Mar 16, 2021

YulNaumenko mentioned this pull request Mar 16, 2021

[7.x] [Alerts] Replaces legacy es client with the ElasticsearchClient for alerts and triggers_actions_ui plugins. (#93364) #94747

Merged

kindsun mentioned this pull request Apr 22, 2021

Fix malformed geo alerts call to transformResults #98094

Merged

nkhristinin mentioned this pull request Sep 10, 2021

Decode file name on upload value lists and fix bug with removing value list #111838

Merged

2 tasks

simianhacker mentioned this pull request Dec 13, 2021

[Stack Monitoring] Stack Monitoring alerts no longer work with monitoring.ui.elasticsearch.* config settings #121129

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Alerts] Replaces legacy es client with the ElasticsearchClient for alerts and triggers_actions_ui plugins. #93364

[Alerts] Replaces legacy es client with the ElasticsearchClient for alerts and triggers_actions_ui plugins. #93364

YulNaumenko commented Mar 3, 2021 •

edited

Loading

elasticmachine commented Mar 3, 2021

elasticmachine commented Mar 6, 2021

igoristic left a comment •

edited

Loading

dhurley14 Mar 15, 2021

elasticmachine commented Mar 16, 2021

shahzad31 left a comment

dhurley14 left a comment

igoristic left a comment

kibanamachine commented Mar 16, 2021

[Alerts] Replaces legacy es client with the ElasticsearchClient for alerts and triggers_actions_ui plugins. #93364

[Alerts] Replaces legacy es client with the ElasticsearchClient for alerts and triggers_actions_ui plugins. #93364

Conversation

YulNaumenko commented Mar 3, 2021 • edited Loading

elasticmachine commented Mar 3, 2021

elasticmachine commented Mar 6, 2021

igoristic left a comment • edited Loading

Choose a reason for hiding this comment

dhurley14 Mar 15, 2021

Choose a reason for hiding this comment

elasticmachine commented Mar 16, 2021

shahzad31 left a comment

Choose a reason for hiding this comment

dhurley14 left a comment

Choose a reason for hiding this comment

igoristic left a comment

Choose a reason for hiding this comment

kibanamachine commented Mar 16, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

History

YulNaumenko commented Mar 3, 2021 •

edited

Loading

igoristic left a comment •

edited

Loading