Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.12][Security] Shellcode telemetry update for schema adjustment #93143

Conversation

gabriellandau
Copy link
Contributor

Summary

This is a fix to the telemetry allowlist for the upcoming 7.12 release. We moved some things around to clarify field names and enable better code reuse in the future.

I am basing this off #92146. Please let me know if I need to do anything additional.

Checklist

Covered by unit tests in

kibana/x-pack/plugins/security_solution/server/lib/telemetry/sender.test.js

For maintainers

@gabriellandau gabriellandau added release_note:fix v7.12.0 Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. labels Mar 1, 2021
@gabriellandau gabriellandau requested review from jeska and pjhampton March 1, 2021 22:39
@gabriellandau gabriellandau requested a review from a team as a code owner March 1, 2021 22:39
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@gabriellandau
Copy link
Contributor Author

@elasticmachine merge upstream

@gabriellandau
Copy link
Contributor Author

@elasticmachine merge upstream

Copy link
Contributor

@pjhampton pjhampton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌔 🚀 ✨ LGTM ✨ 🚀 🌔
cc/ @elastic/security-data-engineering

@pjhampton
Copy link
Contributor

@elasticmachine merge upstream

Copy link
Contributor

@FrankHassanabad FrankHassanabad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jeska jeska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pjhampton
Copy link
Contributor

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
triggersActionsUi 1.6MB 1.5MB -23.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
triggersActionsUi 104.0KB 104.1KB +82.0B
Unknown metric groups

async chunk count

id before after diff
triggersActionsUi 41 42 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@gabriellandau gabriellandau merged commit 3c4595d into elastic:master Mar 2, 2021
@gabriellandau gabriellandau deleted the security-allowlist-update-for-schema-refactor branch March 2, 2021 19:44
gabriellandau added a commit to gabriellandau/kibana that referenced this pull request Mar 2, 2021
…astic#93143)

* Shellcode telemetry update for schema adjustment

* Lint

* Lint

Co-authored-by: Kibana Machine <[email protected]>
gabriellandau added a commit to gabriellandau/kibana that referenced this pull request Mar 2, 2021
…astic#93143)

* Shellcode telemetry update for schema adjustment

* Lint

* Lint

Co-authored-by: Kibana Machine <[email protected]>
gabriellandau added a commit that referenced this pull request Mar 3, 2021
…3143) (#93340)

* Shellcode telemetry update for schema adjustment

* Lint

* Lint

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
gabriellandau added a commit that referenced this pull request Mar 3, 2021
…3143) (#93341)

* Shellcode telemetry update for schema adjustment

* Lint

* Lint

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:fix Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v7.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants