Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.12][Security] Move PE details out of Ext context #92146

Merged
merged 1 commit into from
Feb 22, 2021
Merged

[7.12][Security] Move PE details out of Ext context #92146

merged 1 commit into from
Feb 22, 2021

Conversation

pjhampton
Copy link
Contributor

Summary

This is a fix to the telemetry allowlist for the upcoming 7.12 release. The PE details are in the wrong location.

Checklist

Covered by unit tests in

kibana/x-pack/plugins/security_solution/server/lib/telemetry/sender.test.js

For maintainers

@pjhampton pjhampton added release_note:fix v7.12.0 Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. labels Feb 22, 2021
@pjhampton pjhampton self-assigned this Feb 22, 2021
@pjhampton pjhampton requested a review from a team as a code owner February 22, 2021 11:29
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@pjhampton pjhampton requested a review from Bamieh February 22, 2021 11:29
jeska
jeska approved these changes Feb 22, 2021
View reviewed changes
Copy link
Member

@jeska jeska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @pjhampton !

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @pjhampton

@gabriellandau
Copy link
Contributor

Thanks @pjhampton

stephmilovic
stephmilovic approved these changes Feb 22, 2021
View reviewed changes
Copy link
Contributor

@stephmilovic stephmilovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for leaving the note about the test coverage ❤️

@pjhampton pjhampton merged commit bf9b776 into master Feb 22, 2021
@pjhampton pjhampton deleted the pjhampton/update-security-allowlist branch February 22, 2021 17:16
This was referenced Feb 22, 2021
Merged
Merged
pjhampton added a commit that referenced this pull request Feb 22, 2021
@pjhampton
Move pe details out of Ext context (#92146) (#92241)
6b4b9ff
pjhampton added a commit that referenced this pull request Feb 23, 2021
@pjhampton @kibanamachine
Move pe details out of Ext context (#92146) (#92243)
a26f507 
Co-authored-by: Kibana Machine <[email protected]>
@gabriellandau gabriellandau mentioned this pull request Mar 1, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabriellandau gabriellandau gabriellandau approved these changes

@stephmilovic stephmilovic stephmilovic approved these changes

@jeska jeska jeska approved these changes

@Bamieh Bamieh Awaiting requested review from Bamieh

Assignees

@pjhampton pjhampton

Labels
release_note:fix Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v7.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pjhampton @elasticmachine @kibanamachine @gabriellandau @jeska @stephmilovic