[Fleet] Use type-only imports where possible #92979

jfsiii · 2021-02-26T20:17:34Z

Summary

Use type-only import to differentiate between runtime values and (erasable) TS types.

Allows Babel and tsc to make some optimizations since it can be sure what can be erased.

It can also be helpful in situations like below which highlights that even though KibanaAssetType and KibanaSavedObjectType are named a certain way and from common/types, they are JS values not TS types. They are enums which means they are JS objects at runtime; not eliminated at runtime.

kibana/x-pack/plugins/fleet/common/types/models/epm.ts

Lines 41 to 63 in d92a1a0

    
           /* 
        
             Enum mapping of a saved object asset type to how it would appear in a package file path (snake cased) 
        
           */ 
        
           export enum KibanaAssetType { 
        
             dashboard = 'dashboard', 
        
             visualization = 'visualization', 
        
             search = 'search', 
        
             indexPattern = 'index_pattern', 
        
             map = 'map', 
        
             lens = 'lens', 
        
           } 
        
           /* 
        
            Enum of saved object types that are allowed to be installed 
        
           */ 
        
           export enum KibanaSavedObjectType { 
        
             dashboard = 'dashboard', 
        
             visualization = 'visualization', 
        
             search = 'search', 
        
             indexPattern = 'index-pattern', 
        
             map = 'map', 
        
             lens = 'lens', 
        
           }

jfsiii · 2021-02-26T21:26:59Z

@elasticmachine merge upstream

elasticmachine · 2021-03-01T16:40:29Z

Pinging @elastic/fleet (Team:Fleet)

jen-huang

Nice improvement 👍🏻 Spot checked the files but not all of them.

jfsiii · 2021-03-02T01:59:39Z

@elasticmachine merge upstream

kibanamachine · 2021-03-02T17:10:36Z

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`triggersActionsUi`	1.6MB	1.5MB	-23.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`triggersActionsUi`	104.0KB	104.1KB	+82.0B

Unknown metric groups

async chunk count

id	before	after	diff
`triggersActionsUi`	41	42	+1

History

💔 Build #110184 failed d4f58fb
💚 Build #109764 succeeded c426187
💔 Build #109748 failed e094950
💔 Build #109744 failed 28c8698

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jfsiii

* master: (199 commits) Convert Canvas docs to MDX for use in Elastic Docs (elastic#91969) [Bazel] More resilient Workspace Status (elastic#93244) [Discover] Change icon of saved search in open search panel and embeddable selection (elastic#93001) [Workplace Search] Role Mappings to Kibana (elastic#93123) [Fleet] Use type-only imports where possible (elastic#92979) [Lens] Set pie chart slices sorted clockwise (elastic#92617) Remove ms label from CPU load on status page (elastic#92836) [App Search] Migrate Create Meta Engine View (elastic#92127) [Time to Visualize] Disable Visualize URL Tracker When Linked to OriginatingApp (elastic#92917) [ILM] Allow multiple searchable snapshot actions (elastic#92789) Improve consistency for display of management items (elastic#92694) skip flaky suite (elastic#93152) skip flaky suite (elastic#93152) [ILM] Refactor edit_policy client integration tests into separate feature files (elastic#92826) Add developer documentation about the building blocks we offer plugin developers (elastic#92743) [Security Solution] Case ui enhancement (elastic#91863) [Security Solution] [Detections] Updates warning message when no indices match provided index patterns (elastic#93094) Collect agent telemetry even when fleet server is disabled. (elastic#93198) [Lens] Fix runtime validation error message (elastic#93195) [Lens] Remove warning about ordinal x-domain (elastic#93049) ...

## Summary Use [type-only `import`](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-8.html#type-only-imports-and-export) to differentiate between runtime values and (erasable) TS types. <img width="1499" alt="Screen Shot 2021-02-27 at 6 34 46 PM" src="https://user-images.githubusercontent.com/57655/109403323-84e32c80-792a-11eb-94b7-854d0e5c3e99.png"> Allows Babel and `tsc` to make some optimizations since it can be sure what can be erased. It can also be helpful in situations like below which highlights that even though `KibanaAssetType` and `KibanaSavedObjectType` are named a certain way and from `common/types`, they are JS values _not_ TS types. They are `enum`s which means they are JS objects at runtime; not eliminated at runtime. https://github.com/elastic/kibana/blob/d92a1a08d89accc2fa303b1355a9e222f9b6d090/x-pack/plugins/fleet/common/types/models/epm.ts#L41-L63 # Conflicts: # x-pack/plugins/fleet/server/services/index.ts

…94464) ## Summary Use the [`consistent-type-imports` lint rule ](https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/consistent-type-imports.md) to use `import type ...` where possible Code-only changes like this were recently added in #92979, but it was a more manual process. This PR adds an autofixable lint rule which will keep the changes up-to-date and Just Work ™️

…94464) (#94868) ## Summary Use the [`consistent-type-imports` lint rule ](https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/consistent-type-imports.md) to use `import type ...` where possible Code-only changes like this were recently added in #92979, but it was a more manual process. This PR adds an autofixable lint rule which will keep the changes up-to-date and Just Work ™️ # Conflicts: # x-pack/plugins/fleet/server/services/agents/crud.ts # x-pack/plugins/fleet/server/services/artifacts/artifacts.ts # x-pack/plugins/fleet/server/services/artifacts/mappings.ts # x-pack/plugins/fleet/server/services/artifacts/mocks.ts # x-pack/plugins/fleet/server/services/index.ts

Use 'import type' in Fleet where possible

28c8698

kibanamachine and others added 2 commits February 26, 2021 16:27

Merge branch 'master' into fleet-ts-import-types

e094950

Replace a few lost 'import * as ...'

c426187

jfsiii changed the title ~~[Fleet] Use 'import type' in where possible~~ [Fleet] Use 'import type' where possible Feb 27, 2021

jfsiii changed the title ~~[Fleet] Use 'import type' where possible~~ [Fleet] Use type-onlt imports where possible Feb 27, 2021

jfsiii changed the title ~~[Fleet] Use type-onlt imports where possible~~ [Fleet] Use type-only imports where possible Mar 1, 2021

jfsiii added release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.13.0 v8.0.0 labels Mar 1, 2021

jfsiii self-assigned this Mar 1, 2021

jfsiii requested a review from a team March 1, 2021 14:45

jfsiii marked this pull request as ready for review March 1, 2021 16:40

jen-huang added the chore label Mar 1, 2021

jen-huang approved these changes Mar 1, 2021

View reviewed changes

Merge branch 'master' into fleet-ts-import-types

d4f58fb

jfsiii enabled auto-merge (squash) March 2, 2021 02:00

Merge branch 'master' into fleet-ts-import-types

e914a43

jfsiii merged commit 1702cf9 into elastic:master Mar 2, 2021

jfsiii mentioned this pull request Mar 2, 2021

[7.x] [Fleet] Use type-only imports where possible (#92979) #93268

Merged

jfsiii mentioned this pull request Mar 11, 2021

Use consistent-type-imports lint rule to autofix type-only imports #94464

Merged

jfsiii deleted the fleet-ts-import-types branch April 6, 2021 17:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Fleet] Use type-only imports where possible #92979

[Fleet] Use type-only imports where possible #92979

jfsiii commented Feb 26, 2021 •

edited

Loading

jfsiii commented Feb 26, 2021

elasticmachine commented Mar 1, 2021

jen-huang left a comment

jfsiii commented Mar 2, 2021

kibanamachine commented Mar 2, 2021

async chunk count

	/*
	Enum mapping of a saved object asset type to how it would appear in a package file path (snake cased)
	*/
	export enum KibanaAssetType {
	dashboard = 'dashboard',
	visualization = 'visualization',
	search = 'search',
	indexPattern = 'index_pattern',
	map = 'map',
	lens = 'lens',
	}

	/*
	Enum of saved object types that are allowed to be installed
	*/
	export enum KibanaSavedObjectType {
	dashboard = 'dashboard',
	visualization = 'visualization',
	search = 'search',
	indexPattern = 'index-pattern',
	map = 'map',
	lens = 'lens',
	}

[Fleet] Use type-only imports where possible #92979

[Fleet] Use type-only imports where possible #92979

Conversation

jfsiii commented Feb 26, 2021 • edited Loading

Summary

jfsiii commented Feb 26, 2021

elasticmachine commented Mar 1, 2021

jen-huang left a comment

Choose a reason for hiding this comment

jfsiii commented Mar 2, 2021

kibanamachine commented Mar 2, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

Page load bundle

async chunk count

History

jfsiii commented Feb 26, 2021 •

edited

Loading