Use consistent-type-imports lint rule to autofix type-only imports (#…

…94464)

## Summary

Use the [`consistent-type-imports` lint rule ](https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/consistent-type-imports.md) to use `import type ...` where possible

Code-only changes like this were recently added in #92979, but it was a more manual process.  This PR adds an autofixable lint rule which will keep the changes up-to-date and Just Work ™️

.eslintrc.js

@@ -794,6 +794,7 @@ module.exports = {
     {
       files: ['x-pack/plugins/fleet/**/*.{js,mjs,ts,tsx}'],
       rules: {
+        '@typescript-eslint/consistent-type-imports': 'error',
         'import/order': [
           'warn',
           {

x-pack/plugins/fleet/common/services/license.ts

@@ -5,7 +5,7 @@
  * 2.0.
  */
 
-import { Observable, Subscription } from 'rxjs';
+import type { Observable, Subscription } from 'rxjs';
 
 import type { ILicense } from '../../../licensing/common/types';
 

x-pack/plugins/fleet/common/types/models/agent.ts

@@ -5,7 +5,11 @@
  * 2.0.
  */
 
-import { AGENT_TYPE_EPHEMERAL, AGENT_TYPE_PERMANENT, AGENT_TYPE_TEMPORARY } from '../../constants';
+import type {
+  AGENT_TYPE_EPHEMERAL,
+  AGENT_TYPE_PERMANENT,
+  AGENT_TYPE_TEMPORARY,
+} from '../../constants';
 
 import type { FullAgentPolicy } from './agent_policy';
 

x-pack/plugins/fleet/common/types/models/agent_policy.ts

@@ -5,7 +5,7 @@
  * 2.0.
  */
 
-import { agentPolicyStatuses } from '../../constants';
+import type { agentPolicyStatuses } from '../../constants';
 import type { DataType, ValueOf } from '../../types';
 
 import type { PackagePolicy, PackagePolicyPackage } from './package_policy';

x-pack/plugins/fleet/common/types/models/epm.ts

@@ -9,7 +9,7 @@
 // TODO: Update when https://github.com/elastic/kibana/issues/53021 is closed
 import type { SavedObject, SavedObjectAttributes, SavedObjectReference } from 'src/core/public';
 
-import {
+import type {
   ASSETS_SAVED_OBJECT_TYPE,
   agentAssetTypes,
   dataTypes,

x-pack/plugins/fleet/common/types/models/output.ts

@@ -5,7 +5,7 @@
  * 2.0.
  */
 
-import { outputType } from '../../constants';
+import type { outputType } from '../../constants';
 import type { ValueOf } from '../index';
 
 export type OutputType = typeof outputType;

x-pack/plugins/fleet/public/applications/fleet/app.tsx

@@ -6,16 +6,17 @@
  */
 
 import React, { memo, useEffect, useState } from 'react';
-import { AppMountParameters } from 'kibana/public';
+import type { AppMountParameters } from 'kibana/public';
 import { EuiCode, EuiEmptyPrompt, EuiErrorBoundary, EuiPanel } from '@elastic/eui';
-import { createHashHistory, History } from 'history';
+import type { History } from 'history';
+import { createHashHistory } from 'history';
 import { Router, Redirect, Route, Switch } from 'react-router-dom';
 import { FormattedMessage } from '@kbn/i18n/react';
 import { i18n } from '@kbn/i18n';
 import styled from 'styled-components';
 import useObservable from 'react-use/lib/useObservable';
 
-import { FleetConfigType, FleetStartServices } from '../../plugin';
+import type { FleetConfigType, FleetStartServices } from '../../plugin';
 import { KibanaContextProvider } from '../../../../../../src/plugins/kibana_react/public';
 import { EuiThemeProvider } from '../../../../../../src/plugins/kibana_react/common';
 
@@ -39,7 +40,7 @@ import { DataStreamApp } from './sections/data_stream';
 import { FleetApp } from './sections/agents';
 import { IngestManagerOverview } from './sections/overview';
 import { ProtectedRoute } from './index';
-import { UIExtensionsStorage } from './types';
+import type { UIExtensionsStorage } from './types';
 import { UIExtensionsContext } from './hooks/use_ui_extension';
 
 const ErrorLayout = ({ children }: { children: JSX.Element }) => (

x-pack/plugins/fleet/public/applications/fleet/components/context_menu_actions.tsx

@@ -14,9 +14,9 @@ import {
   EuiPopover,
   EuiButton,
 } from '@elastic/eui';
-import { EuiButtonProps } from '@elastic/eui/src/components/button/button';
-import { EuiContextMenuProps } from '@elastic/eui/src/components/context_menu/context_menu';
-import { EuiContextMenuPanelProps } from '@elastic/eui/src/components/context_menu/context_menu_panel';
+import type { EuiButtonProps } from '@elastic/eui/src/components/button/button';
+import type { EuiContextMenuProps } from '@elastic/eui/src/components/context_menu/context_menu';
+import type { EuiContextMenuPanelProps } from '@elastic/eui/src/components/context_menu/context_menu_panel';
 
 type Props = {
   button?: {

x-pack/plugins/fleet/public/applications/fleet/components/enrollment_instructions/manual/index.tsx

@@ -10,7 +10,7 @@ import styled from 'styled-components';
 import { EuiText, EuiSpacer, EuiLink, EuiTitle, EuiCodeBlock } from '@elastic/eui';
 import { FormattedMessage } from '@kbn/i18n/react';
 
-import { EnrollmentAPIKey } from '../../../types';
+import type { EnrollmentAPIKey } from '../../../types';
 
 interface Props {
   kibanaUrl: string;

x-pack/plugins/fleet/public/applications/fleet/components/extension_wrapper.tsx

@@ -5,7 +5,8 @@
  * 2.0.
  */
 
-import React, { memo, ReactNode, Suspense } from 'react';
+import type { ReactNode } from 'react';
+import React, { memo, Suspense } from 'react';
 import { EuiErrorBoundary } from '@elastic/eui';
 
 import { Loading } from './loading';

x-pack/plugins/fleet/public/applications/fleet/components/header.tsx

@@ -8,8 +8,8 @@
 import React, { memo } from 'react';
 import styled from 'styled-components';
 import { EuiFlexGroup, EuiFlexItem, EuiTabs, EuiTab, EuiSpacer } from '@elastic/eui';
-import { Props as EuiTabProps } from '@elastic/eui/src/components/tabs/tab';
-import { EuiFlexItemProps } from '@elastic/eui/src/components/flex/flex_item';
+import type { Props as EuiTabProps } from '@elastic/eui/src/components/tabs/tab';
+import type { EuiFlexItemProps } from '@elastic/eui/src/components/flex/flex_item';
 
 const Container = styled.div`
   border-bottom: ${(props) => props.theme.eui.euiBorderThin};

x-pack/plugins/fleet/public/applications/fleet/components/home_integration/tutorial_module_notice.tsx

@@ -8,7 +8,7 @@
 import React, { memo } from 'react';
 import { FormattedMessage } from '@kbn/i18n/react';
 import { EuiText, EuiLink, EuiSpacer } from '@elastic/eui';
-import { TutorialModuleNoticeComponent } from 'src/plugins/home/public';
+import type { TutorialModuleNoticeComponent } from 'src/plugins/home/public';
 
 import { useGetPackages, useLink, useCapabilities } from '../../hooks';
 import { pkgKeyFromPackageInfo } from '../../services/pkg_key_from_package_info';

x-pack/plugins/fleet/public/applications/fleet/components/link_and_revision.tsx

@@ -7,8 +7,9 @@
 
 import { EuiFlexGroup, EuiFlexItem, EuiLink, EuiText } from '@elastic/eui';
 import { FormattedMessage } from '@kbn/i18n/react';
-import React, { CSSProperties, memo } from 'react';
-import { EuiLinkProps } from '@elastic/eui/src/components/link/link';
+import type { CSSProperties } from 'react';
+import React, { memo } from 'react';
+import type { EuiLinkProps } from '@elastic/eui/src/components/link/link';
 
 const MIN_WIDTH: CSSProperties = { minWidth: 0 };
 const NO_WRAP_WHITE_SPACE: CSSProperties = { whiteSpace: 'nowrap' };

x-pack/plugins/fleet/public/applications/fleet/components/linked_agent_count.tsx

@@ -6,7 +6,8 @@
  */
 
 import React, { memo } from 'react';
-import { EuiLink, EuiLinkAnchorProps } from '@elastic/eui';
+import type { EuiLinkAnchorProps } from '@elastic/eui';
+import { EuiLink } from '@elastic/eui';
 
 import { useLink } from '../hooks';
 import { AGENT_SAVED_OBJECT_TYPE } from '../constants';

x-pack/plugins/fleet/public/applications/fleet/components/loading.tsx

@@ -7,7 +7,7 @@
 
 import React from 'react';
 import { EuiFlexGroup, EuiFlexItem, EuiLoadingSpinner } from '@elastic/eui';
-import { EuiLoadingSpinnerSize } from '@elastic/eui/src/components/loading/loading_spinner';
+import type { EuiLoadingSpinnerSize } from '@elastic/eui/src/components/loading/loading_spinner';
 
 export const Loading: React.FunctionComponent<{ size?: EuiLoadingSpinnerSize }> = ({ size }) => (
   <EuiFlexGroup justifyContent="spaceAround">

x-pack/plugins/fleet/public/applications/fleet/components/package_icon.tsx

@@ -6,9 +6,11 @@
  */
 
 import React from 'react';
-import { EuiIcon, EuiIconProps } from '@elastic/eui';
+import type { EuiIconProps } from '@elastic/eui';
+import { EuiIcon } from '@elastic/eui';
 
-import { usePackageIconType, UsePackageIconType } from '../hooks';
+import type { UsePackageIconType } from '../hooks';
+import { usePackageIconType } from '../hooks';
 
 export const PackageIcon: React.FunctionComponent<
   UsePackageIconType & Omit<EuiIconProps, 'type'>

x-pack/plugins/fleet/public/applications/fleet/components/search_bar.tsx

@@ -7,11 +7,8 @@
 
 import React, { useState, useEffect, useMemo } from 'react';
 
-import {
-  QueryStringInput,
-  IFieldType,
-  esKuery,
-} from '../../../../../../../src/plugins/data/public';
+import type { IFieldType } from '../../../../../../../src/plugins/data/public';
+import { QueryStringInput, esKuery } from '../../../../../../../src/plugins/data/public';
 import { useStartServices } from '../hooks';
 import { INDEX_NAME, AGENT_SAVED_OBJECT_TYPE } from '../constants';
 

x-pack/plugins/fleet/public/applications/fleet/hooks/use_breadcrumbs.tsx

@@ -6,9 +6,10 @@
  */
 
 import { i18n } from '@kbn/i18n';
-import { ChromeBreadcrumb } from 'src/core/public';
+import type { ChromeBreadcrumb } from 'src/core/public';
 
-import { BASE_PATH, Page, DynamicPagePathValues, pagePathGetters } from '../constants';
+import type { Page, DynamicPagePathValues } from '../constants';
+import { BASE_PATH, pagePathGetters } from '../constants';
 
 import { useStartServices } from './use_core';
 

x-pack/plugins/fleet/public/applications/fleet/hooks/use_fleet_status.tsx

@@ -7,7 +7,7 @@
 
 import React, { useState, useContext, useEffect } from 'react';
 
-import { GetFleetStatusResponse } from '../types';
+import type { GetFleetStatusResponse } from '../types';
 
 import { useConfig } from './use_config';
 import { sendGetFleetStatus } from './use_request';

x-pack/plugins/fleet/public/applications/fleet/hooks/use_intra_app_state.tsx

@@ -6,10 +6,10 @@
  */
 
 import React, { memo, useContext, useMemo } from 'react';
-import { AppMountParameters } from 'kibana/public';
+import type { AppMountParameters } from 'kibana/public';
 import { useLocation } from 'react-router-dom';
 
-import { AnyIntraAppRouteState } from '../types';
+import type { AnyIntraAppRouteState } from '../types';
 
 interface IntraAppState<S extends AnyIntraAppRouteState = AnyIntraAppRouteState> {
   forRoute: string;

x-pack/plugins/fleet/public/applications/fleet/hooks/use_request/use_request.ts

@@ -9,18 +9,18 @@ import { useState, useEffect } from 'react';
 import type { HttpSetup } from 'src/core/public';
 
 import {
-  UseRequestConfig as _UseRequestConfig,
   sendRequest as _sendRequest,
   useRequest as _useRequest,
 } from '../../../../../../../../src/plugins/es_ui_shared/public';
 import type {
   SendRequestConfig,
   SendRequestResponse,
+  UseRequestConfig,
 } from '../../../../../../../../src/plugins/es_ui_shared/public';
 
 let httpClient: HttpSetup;
 
-export type UseRequestConfig = _UseRequestConfig;
+export type { UseRequestConfig } from '../../../../../../../../src/plugins/es_ui_shared/public';
 
 /**
  * @internal

x-pack/plugins/fleet/public/applications/fleet/hooks/use_sorting.tsx

@@ -6,7 +6,7 @@
  */
 
 import { useState } from 'react';
-import { CriteriaWithPagination } from '@elastic/eui/src/components/basic_table/basic_table';
+import type { CriteriaWithPagination } from '@elastic/eui/src/components/basic_table/basic_table';
 
 export function useSorting<T>(defaultSorting: CriteriaWithPagination<T>['sort']) {
   const [sorting, setSorting] = useState<CriteriaWithPagination<T>['sort']>(defaultSorting);

x-pack/plugins/fleet/public/applications/fleet/index.tsx

@@ -7,13 +7,14 @@
 
 import React from 'react';
 import ReactDOM from 'react-dom';
-import { Redirect, Route, RouteProps } from 'react-router-dom';
-import { CoreStart, AppMountParameters } from 'src/core/public';
+import type { RouteProps } from 'react-router-dom';
+import { Redirect, Route } from 'react-router-dom';
+import type { CoreStart, AppMountParameters } from 'src/core/public';
 
-import { FleetConfigType, FleetStartServices } from '../../plugin';
+import type { FleetConfigType, FleetStartServices } from '../../plugin';
 
 import { licenseService } from './hooks';
-import { UIExtensionsStorage } from './types';
+import type { UIExtensionsStorage } from './types';
 import { AppRoutes, FleetAppContext, WithPermissionsAndSetup } from './app';
 
 export interface ProtectedRouteProps extends RouteProps {

x-pack/plugins/fleet/public/applications/fleet/layouts/default.tsx

@@ -10,7 +10,7 @@ import styled from 'styled-components';
 import { EuiTabs, EuiTab, EuiFlexGroup, EuiFlexItem, EuiButtonEmpty } from '@elastic/eui';
 import { FormattedMessage } from '@kbn/i18n/react';
 
-import { Section } from '../sections';
+import type { Section } from '../sections';
 import { AlphaMessaging, SettingFlyout } from '../components';
 import { useLink, useConfig } from '../hooks';
 

x-pack/plugins/fleet/public/applications/fleet/layouts/with_header.tsx

@@ -8,7 +8,8 @@
 import React, { Fragment } from 'react';
 import { EuiPageBody, EuiSpacer } from '@elastic/eui';
 
-import { Header, HeaderProps } from '../components';
+import type { HeaderProps } from '../components';
+import { Header } from '../components';
 
 import { Page, ContentWrapper } from './without_header';
 

x-pack/plugins/fleet/public/applications/fleet/mock/create_test_renderer.tsx

@@ -5,19 +5,21 @@
  * 2.0.
  */
 
-import { createMemoryHistory, History, createHashHistory } from 'history';
+import type { History } from 'history';
+import { createMemoryHistory, createHashHistory } from 'history';
 import React, { memo } from 'react';
-import { render as reactRender, RenderOptions, RenderResult, act } from '@testing-library/react';
+import type { RenderOptions, RenderResult } from '@testing-library/react';
+import { render as reactRender, act } from '@testing-library/react';
 
 import { ScopedHistory } from '../../../../../../../src/core/public';
 import { FleetAppContext } from '../app';
-import { FleetConfigType } from '../../../plugin';
-import { UIExtensionsStorage } from '../types';
+import type { FleetConfigType } from '../../../plugin';
+import type { UIExtensionsStorage } from '../types';
 
 import { createConfigurationMock } from './plugin_configuration';
 import { createStartMock } from './plugin_interfaces';
 import { createStartServices } from './fleet_start_services';
-import { MockedFleetStart, MockedFleetStartServices } from './types';
+import type { MockedFleetStart, MockedFleetStartServices } from './types';
 
 type UiRender = (ui: React.ReactElement, options?: RenderOptions) => RenderResult;
 

x-pack/plugins/fleet/public/applications/fleet/mock/fleet_start_services.tsx

@@ -7,14 +7,15 @@
 
 import React from 'react';
 import { I18nProvider } from '@kbn/i18n/react';
-import { MockedKeys } from '@kbn/utility-types/jest';
+import type { MockedKeys } from '@kbn/utility-types/jest';
 
 import { coreMock } from '../../../../../../../src/core/public/mocks';
-import { IStorage, Storage } from '../../../../../../../src/plugins/kibana_utils/public';
+import type { IStorage } from '../../../../../../../src/plugins/kibana_utils/public';
+import { Storage } from '../../../../../../../src/plugins/kibana_utils/public';
 import { setHttpClient } from '../hooks/use_request';
 
 import { createStartDepsMock } from './plugin_dependencies';
-import { MockedFleetStartServices } from './types';
+import type { MockedFleetStartServices } from './types';
 
 // Taken from core. See: src/plugins/kibana_utils/public/storage/storage.test.ts
 const createMockStore = (): MockedKeys<IStorage> => {

x-pack/plugins/fleet/public/applications/fleet/sections/agent_policy/components/actions_menu.tsx

@@ -9,7 +9,7 @@ import React, { memo, useState, useMemo } from 'react';
 import { FormattedMessage } from '@kbn/i18n/react';
 import { EuiContextMenuItem, EuiPortal } from '@elastic/eui';
 
-import { AgentPolicy } from '../../../types';
+import type { AgentPolicy } from '../../../types';
 import { useCapabilities } from '../../../hooks';
 import { ContextMenuActions } from '../../../components';
 import { AgentEnrollmentFlyout } from '../../agents/components';

x-pack/plugins/fleet/public/applications/fleet/sections/agent_policy/components/agent_policy_copy_provider.tsx

@@ -10,7 +10,7 @@ import { EuiConfirmModal, EuiFormRow, EuiFieldText } from '@elastic/eui';
 import { i18n } from '@kbn/i18n';
 import { FormattedMessage } from '@kbn/i18n/react';
 
-import { AgentPolicy } from '../../../types';
+import type { AgentPolicy } from '../../../types';
 import { sendCopyAgentPolicy, useStartServices } from '../../../hooks';
 
 interface Props {

x-pack/plugins/fleet/public/applications/fleet/sections/agent_policy/components/agent_policy_form.tsx

@@ -26,7 +26,7 @@ import { i18n } from '@kbn/i18n';
 import styled from 'styled-components';
 
 import { dataTypes } from '../../../../../../common';
-import { NewAgentPolicy, AgentPolicy } from '../../../types';
+import type { NewAgentPolicy, AgentPolicy } from '../../../types';
 import { isValidNamespace } from '../../../services';
 
 import { AgentPolicyDeleteProvider } from './agent_policy_delete_provider';

x-pack/plugins/fleet/public/applications/fleet/sections/agent_policy/components/confirm_deploy_modal.tsx

@@ -10,7 +10,7 @@ import { EuiCallOut, EuiConfirmModal, EuiSpacer } from '@elastic/eui';
 import { FormattedMessage } from '@kbn/i18n/react';
 import { i18n } from '@kbn/i18n';
 
-import { AgentPolicy } from '../../../types';
+import type { AgentPolicy } from '../../../types';
 
 export const ConfirmDeployAgentPolicyModal: React.FunctionComponent<{
   onConfirm: () => void;

x-pack/plugins/fleet/public/applications/fleet/sections/agent_policy/components/package_policy_delete_provider.tsx

@@ -12,7 +12,7 @@ import { FormattedMessage } from '@kbn/i18n/react';
 
 import { useStartServices, sendRequest, sendDeletePackagePolicy, useConfig } from '../../../hooks';
 import { AGENT_API_ROUTES, AGENT_SAVED_OBJECT_TYPE } from '../../../constants';
-import { AgentPolicy } from '../../../types';
+import type { AgentPolicy } from '../../../types';
 
 interface Props {
   agentPolicy: AgentPolicy;