Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Console] Update autocomplete definitions for component templates #92915

Conversation

alisonelizabeth
Copy link
Contributor

Follow-up to #91180.

After opening the backport PR for the above code change, I realized that there was already autocomplete definitions for the component templates API on 7.x and the current changes in master were incomplete. This aligns the branches.

@alisonelizabeth alisonelizabeth added Feature:Console Dev Tools Console Feature v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes v7.13.0 labels Feb 25, 2021
@alisonelizabeth alisonelizabeth requested a review from a team as a code owner February 25, 2021 21:23
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@alisonelizabeth
Copy link
Contributor Author

@elasticmachine merge upstream

@alisonelizabeth
Copy link
Contributor Author

@elasticmachine merge upstream

@alisonelizabeth
Copy link
Contributor Author

@elasticmachine merge upstream

@alisonelizabeth
Copy link
Contributor Author

@elasticmachine merge upstream

@cuff-links
Copy link
Contributor

Testing this locally.

Copy link
Contributor

@cuff-links cuff-links left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works locally. Tested all of the params. LGTM.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@alisonelizabeth alisonelizabeth merged commit 5744f2b into elastic:master Mar 9, 2021
@alisonelizabeth alisonelizabeth deleted the console/update_component_templates branch March 9, 2021 14:06
alisonelizabeth added a commit that referenced this pull request Mar 9, 2021
# Conflicts:
#	src/plugins/console/server/lib/spec_definitions/json/generated/cluster.get_component_template.json
#	src/plugins/console/server/lib/spec_definitions/json/generated/cluster.put_component_template.json
#	src/plugins/console/server/lib/spec_definitions/json/overrides/cluster.put_component_template.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Console Dev Tools Console Feature release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.13.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants