autocompletion of component_templates #91180

joxley-elastic · 2021-02-11T18:39:10Z

Summary

In the dev console, working with component_templates autocomplete will only provide suggestions for deleting them. This set of fixes atteempts to add in support to autocomplete puts and gets for component templates

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

For maintainers

This was checked for breaking API changes and was labeled appropriately

In the dev console, working with component_templates autocomplete will only provide suggestions for deleting them. This set of fixes adds in support to autocomplete puts and gets for component templates

elasticmachine · 2021-02-11T18:39:12Z

Pinging @elastic/es-ui (Team:Elasticsearch UI)

alisonelizabeth

Thanks for the contribution @joxley-elastic! I left a few comments that I think need to be addressed before merging.

I also think we can add a file to the overrides directory to provide autocomplete suggestions for the request body when creating a component template. @cuff-links do you think you can help with this?

alisonelizabeth · 2021-02-16T17:21:10Z

...ugins/console/server/lib/spec_definitions/json/generated/cluster.get_component_template.json

+{
+  "indices.get_template": {
+    "url_params": {
+      "include_type_name": "__flag__",


I don't think this is a valid flag in 8.0

I went ahead and removed this.

...ugins/console/server/lib/spec_definitions/json/generated/cluster.get_component_template.json

...ugins/console/server/lib/spec_definitions/json/generated/cluster.put_component_template.json

alisonelizabeth · 2021-02-16T17:25:26Z

@elasticmachine merge upstream

alisonelizabeth · 2021-02-16T17:25:55Z

This PR should resolve #75967.

alisonelizabeth · 2021-02-16T18:49:06Z

I'm removing the 7.12 label for now, since FF is today.

cuff-links · 2021-02-18T22:19:20Z

Thanks for the contribution @joxley-elastic! I left a few comments that I think need to be addressed before merging.

I also think we can add a file to the overrides directory to provide autocomplete suggestions for the request body when creating a component template. @cuff-links do you think you can help with this?

@alisonelizabeth I can help with these overrides.

cuff-links · 2021-02-19T19:53:56Z

Reviewing

cuff-links · 2021-02-24T09:00:30Z

I have a commit ready to push. Just figuring out how to push it to this PR. Should have it up today though.

cuff-links · 2021-02-25T04:52:01Z

Pushed the overrides and tested the autocompletions locally. @joxley-elastic @alisonelizabeth

…y-component-autocomplete

…/cluster.get_component_template.json

…/cluster.put_component_template.json

alisonelizabeth · 2021-02-25T16:28:32Z

Thanks @cuff-links! Looks great.

alisonelizabeth

Latest LGTM. I went ahead and addressed the comments I had added previously. I will handle merging/backporting once CI is green. Thanks so much for the contribution @joxley-elastic!

kibanamachine · 2021-02-25T18:21:54Z

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

💚 Build #109299 succeeded 07cc1a5
💚 Build #106925 succeeded a8986de
💛 Build #106156 was flaky 91df39b

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @joxley-elastic

* [Console] Autocompletion of component_templates (#91180) # Conflicts: # src/plugins/console/server/lib/spec_definitions/json/generated/cluster.get_component_template.json # src/plugins/console/server/lib/spec_definitions/json/generated/cluster.put_component_template.json # src/plugins/console/server/lib/spec_definitions/json/overrides/cluster.put_component_template.json * update backport Co-authored-by: joxley-elastic <[email protected]>

Add files via upload

91df39b

In the dev console, working with component_templates autocomplete will only provide suggestions for deleting them. This set of fixes adds in support to autocomplete puts and gets for component templates

joxley-elastic added v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.12.0 labels Feb 11, 2021

joxley-elastic requested a review from a team as a code owner February 11, 2021 18:39

joxley-elastic self-assigned this Feb 11, 2021

cjcenizal added Feature:Console Dev Tools Console Feature Feature:Dev Tools release_note:skip Skip the PR/issue when compiling release notes labels Feb 11, 2021

alisonelizabeth requested changes Feb 16, 2021

View reviewed changes

Merge branch 'master' into joxley-component-autocomplete

a8986de

alisonelizabeth requested a review from cuff-links February 16, 2021 17:26

alisonelizabeth removed the v7.12.0 label Feb 16, 2021

cjcenizal added the v7.13.0 label Feb 17, 2021

Added overrides for request body

07cc1a5

alisonelizabeth and others added 4 commits February 25, 2021 11:13

Merge branch 'master' of https://github.com/elastic/kibana into joxle…

3f0005a

…y-component-autocomplete

Update src/plugins/console/server/lib/spec_definitions/json/generated…

d7cf323

…/cluster.get_component_template.json

Update src/plugins/console/server/lib/spec_definitions/json/generated…

b11a245

…/cluster.put_component_template.json

remove inapplicable params

65aacde

alisonelizabeth approved these changes Feb 25, 2021

View reviewed changes

alisonelizabeth merged commit 06d966e into master Feb 25, 2021

alisonelizabeth deleted the joxley-component-autocomplete branch February 25, 2021 18:31

alisonelizabeth mentioned this pull request Feb 25, 2021

[7.x] [Console] Autocompletion of component_templates (#91180) #92884

Merged

alisonelizabeth mentioned this pull request Feb 25, 2021

[Console] Update autocomplete definitions for component templates #92915

Merged

mibragimov mentioned this pull request Jan 31, 2022

[Console] Support suggesting index templates v2 #75967

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

autocompletion of component_templates #91180

autocompletion of component_templates #91180

joxley-elastic commented Feb 11, 2021 •

edited by timroes

Loading

elasticmachine commented Feb 11, 2021

alisonelizabeth left a comment •

edited

Loading

alisonelizabeth Feb 16, 2021

alisonelizabeth Feb 25, 2021

alisonelizabeth commented Feb 16, 2021

alisonelizabeth commented Feb 16, 2021

alisonelizabeth commented Feb 16, 2021

cuff-links commented Feb 18, 2021

cuff-links commented Feb 19, 2021

cuff-links commented Feb 24, 2021 •

edited

Loading

cuff-links commented Feb 25, 2021

alisonelizabeth commented Feb 25, 2021

alisonelizabeth left a comment

kibanamachine commented Feb 25, 2021

autocompletion of component_templates #91180

autocompletion of component_templates #91180

Conversation

joxley-elastic commented Feb 11, 2021 • edited by timroes Loading

Summary

Checklist

For maintainers

elasticmachine commented Feb 11, 2021

alisonelizabeth left a comment • edited Loading

Choose a reason for hiding this comment

alisonelizabeth Feb 16, 2021

Choose a reason for hiding this comment

alisonelizabeth Feb 25, 2021

Choose a reason for hiding this comment

alisonelizabeth commented Feb 16, 2021

alisonelizabeth commented Feb 16, 2021

alisonelizabeth commented Feb 16, 2021

cuff-links commented Feb 18, 2021

cuff-links commented Feb 19, 2021

cuff-links commented Feb 24, 2021 • edited Loading

cuff-links commented Feb 25, 2021

alisonelizabeth commented Feb 25, 2021

alisonelizabeth left a comment

Choose a reason for hiding this comment

kibanamachine commented Feb 25, 2021

💚 Build Succeeded

Metrics [docs]

History

joxley-elastic commented Feb 11, 2021 •

edited by timroes

Loading

alisonelizabeth left a comment •

edited

Loading

cuff-links commented Feb 24, 2021 •

edited

Loading