Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Data Frame Analytics: Adds missing info icon tooltips to scatterplot matrix option labels. #92626

Merged
merged 3 commits into from
Feb 24, 2021
Merged

[ML] Data Frame Analytics: Adds missing info icon tooltips to scatterplot matrix option labels. #92626

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dc5348d
[ML] Adds missing info icon tooltips to scatterplot matrix option lab…
walterra Feb 24, 2021
15f2a46
[ML] Fix i18n id.
walterra Feb 24, 2021
247d514
[ML] Fix interface name
walterra Feb 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 60 additions & 12 deletions x-pack/plugins/ml/public/application/components/scatterplot_matrix/scatterplot_matrix.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import {
EuiFlexGroup,
EuiFlexItem,
EuiFormRow,
EuiIconTip,
EuiSelect,
EuiSpacer,
EuiSwitch,
Expand Down Expand Up @@ -57,6 +58,24 @@ const TOGGLE_OFF = i18n.translate('xpack.ml.splom.toggleOff', {

const sampleSizeOptions = [100, 1000, 10000].map((d) => ({ value: d, text: '' + d }));

interface OptionLabelWithIconTipProps {
label: string;
tooltip: string;
}

const OptionLabelWithIconTip: FC<OptionLabelWithIconTipProps> = ({ label, tooltip }) => (
<>
{label}
<EuiIconTip
content={tooltip}
iconProps={{
className: 'eui-alignTop',
}}
size="s"
/>
</>
);

export interface ScatterplotMatrixProps {
fields: string[];
index: string;
Expand Down Expand Up @@ -252,9 +271,16 @@ export const ScatterplotMatrix: FC<ScatterplotMatrixProps> = ({
<EuiFlexGroup>
<EuiFlexItem>
<EuiFormRow
label={i18n.translate('xpack.ml.splom.fieldSelectionLabel', {
defaultMessage: 'Fields',
})}
label={
<OptionLabelWithIconTip
label={i18n.translate('xpack.ml.splom.fieldSelectionLabel', {
defaultMessage: 'Fields',
})}
tooltip={i18n.translate('xpack.ml.splom.fieldSelectionInfoTooltip', {
defaultMessage: 'Pick fields to explore their relationships.',
})}
/>
}
display="rowCompressed"
fullWidth
>
Expand All @@ -276,9 +302,16 @@ export const ScatterplotMatrix: FC<ScatterplotMatrixProps> = ({
</EuiFlexItem>
<EuiFlexItem style={{ width: '200px' }} grow={false}>
<EuiFormRow
label={i18n.translate('xpack.ml.splom.sampleSizeLabel', {
defaultMessage: 'Sample size',
})}
label={
<OptionLabelWithIconTip
label={i18n.translate('xpack.ml.splom.sampleSizeLabel', {
defaultMessage: 'Sample size',
})}
tooltip={i18n.translate('xpack.ml.splom.sampleSizeInfoTooltip', {
defaultMessage: 'Amount of documents to display in the scatterplot matrix.',
})}
/>
}
display="rowCompressed"
fullWidth
>
Expand All @@ -292,9 +325,17 @@ export const ScatterplotMatrix: FC<ScatterplotMatrixProps> = ({
</EuiFlexItem>
<EuiFlexItem style={{ width: '120px' }} grow={false}>
<EuiFormRow
label={i18n.translate('xpack.ml.splom.randomScoringLabel', {
defaultMessage: 'Random scoring',
})}
label={
<OptionLabelWithIconTip
label={i18n.translate('xpack.ml.splom.randomScoringLabel', {
defaultMessage: 'Random scoring',
})}
tooltip={i18n.translate('xpack.ml.splom.randomScoringInfoTooltip', {
defaultMessage:
'Uses a function score query to get randomly selected documents as the sample.',
})}
/>
}
display="rowCompressed"
fullWidth
>
Expand All @@ -310,9 +351,16 @@ export const ScatterplotMatrix: FC<ScatterplotMatrixProps> = ({
{resultsField !== undefined && legendType === undefined && (
<EuiFlexItem style={{ width: '120px' }} grow={false}>
<EuiFormRow
label={i18n.translate('xpack.ml.splom.dynamicSizeLabel', {
defaultMessage: 'Dynamic size',
})}
label={
<OptionLabelWithIconTip
label={i18n.translate('xpack.ml.splom.dynamicSizeLabel', {
defaultMessage: 'Dynamic size',
})}
tooltip={i18n.translate('xpack.ml.splom.dynamicSizeInfoTooltip', {
defaultMessage: 'Scales the size of each point by its outlier score.',
})}
/>
}
display="rowCompressed"
fullWidth
>
Expand Down